Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation for ignore_deleted option #61

Closed
wants to merge 1 commit into from

Conversation

rwyland
Copy link
Contributor

@rwyland rwyland commented Oct 20, 2023

This is a code-complete feature to resolve #58

Currently untested, please either point me to some instructions for testing, or provide additional test results in this PR - thanks

@rwyland rwyland changed the title Impl for ignore_delete option Impl for ignore_deleted option Oct 22, 2023
@rwyland rwyland changed the title Impl for ignore_deleted option Implementation for ignore_deleted option Oct 22, 2023
@rwyland
Copy link
Contributor Author

rwyland commented Oct 24, 2023

Pinging @JavierCane and @rgomezcasas

@MaferMazu
Copy link

Thanks for this PR. It would be beneficial to have this.

@OnkarRuikar
Copy link
Contributor

+1 bump

@mastercactapus
Copy link

bump, looking for this before enabling fail_if_xl

@johnlk johnlk mentioned this pull request Apr 17, 2024
5 tasks
@johnlk
Copy link
Collaborator

johnlk commented May 14, 2024

Merged with #76 which was a PR inspired by this PR but with updated conventions and unit tests. @rwyland was tagged as a co-author in that change

@johnlk johnlk closed this May 14, 2024
@rwyland rwyland deleted the rw/feature/ignore-deleted branch May 15, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can ignore deletions?
5 participants