Clicking Copy shows the Copied message multiple times

[DanyCaissy]

Issues to fix:

• When clicking copy, the alert appears twice, instead of once
• Clicking copy creates a # in the URL and moves the page up, it also shouldn't do so.
• The "copied!" messages should be reworded to "The data has been copied to your clipboard. hit Ctrl-V in your spreadsheet editor to paste the data" to clarify the action to the user.

Current behaviour on 5.4 with plugins on development:

[DanyCaissy]

I've retested the "double copied message" issue and it doesn't always happen. I've identified a scenario where it happens, it seems to happen if there is a table as well as a non-table chart.

To reproduce:

double-copy.zip

[contactashish13]

this is related to the problem explained in #591 and #600 as explained in #600 (comment).

I've marked it as critical as this will have the same UX repercussions as #591 and will need to be tested equally extensively.

Also related to #689

PR #692

[DanyCaissy]

@contactashish13 I couldn't reproduce the issue anymore (I had to clear cache first).

Please also reword the message as above.

Thanks

[rodica-andronache]

@DanyCaissy this part of the issue is still happening for me. Is that ok?
"Clicking copy creates a # in the URL and moves the page up, it also shouldn't do so."

Otherwise, it's working well for me

[DanyCaissy]

Yes the # should be fixed as well.

[contactashish13]

@rodica-andronache addressed this as well.

Because this issue is related to #689, this may need to be extensively tested.