Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@/CivicSignalBlog - Add ability to manage CivicSignal content #901

Merged
merged 34 commits into from
Sep 25, 2024

Conversation

m453h
Copy link
Contributor

@m453h m453h commented Sep 20, 2024

Description

This PR enhances the CivicSignalBlog by adding the ability to manage CivicSignal web-tools content.

This implementation allows users to switch between different instances of the web-tools which include:

  • Research Blog
  • CivicSignal Site
  • Explorer
  • Topic Mapper
  • Source Manager

This initial implementation only supports:

  • Pages Collection: Allows managing basic pages specific to each tool.
  • Global Settings: Includes global configuration options for each of the above applications.

This PR focuses on simplicity and paves the way for future enhancements.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Screenshots

Screenshot 2024-09-20 at 17 08 02

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@m453h m453h added the enhancement New feature or request label Sep 20, 2024
@m453h m453h self-assigned this Sep 20, 2024
@m453h m453h marked this pull request as ready for review September 23, 2024 06:10
Copy link
Contributor

@koechkevin koechkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good... kudos


  1. Isn't there a way of using URL for switch apps? Or at least show the current app as part of the URL i.e. http://localhost:3000/admin/research or http://localhost:3000/admin?app=research or something.
  2. Lets move the app switch to where user/locale is.
Screenshot 2024-09-23 at 14 35 27

apps/civicsignalblog/src/lib/data/json/applications.js Outdated Show resolved Hide resolved
apps/civicsignalblog/src/lib/data/json/applications.js Outdated Show resolved Hide resolved
apps/civicsignalblog/tsconfig.json Outdated Show resolved Hide resolved
apps/civicsignalblog/src/payload/collections/Users.js Outdated Show resolved Hide resolved
@m453h
Copy link
Contributor Author

m453h commented Sep 24, 2024

Looks really good... kudos

  1. Isn't there a way of using URL for switch apps? Or at least show the current app as part of the URL i.e. http://localhost:3000/admin/research or http://localhost:3000/admin?app=research or something.
  2. Lets move the app switch to where user/locale is.
Screenshot 2024-09-23 at 14 35 27

I've made the switch, we can show the URL based on the App the user has switched to when we redirect to the homepage but we will loose it whenever we click any other link, the same behaviour is observed for the user locale.
ezgif-1-c7d30d5837

@kilemensi
Copy link
Member

I've made the switch, we can show the URL based on the App the user has switched to when we redirect to the homepage but we will loose it whenever we click any other link ...

Cool @m453h . It's minor so we can leave it out for now since everything is CivicSignal.

Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@m453h m453h added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 159a220 Sep 25, 2024
4 checks passed
@m453h m453h deleted the feat/civic_signal_webtools_cms branch September 25, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants