Private field discrepanices

[bschoenfeld]

When you register, it says your last name will private. Your last name is shown when you adopt a drain (even to people who are not logged in). When you login and check your profile, it says your last name is not private. There are some other privacy options advertised in registration that don't match the reality of the app.

Registration

Adopted Drain View

Profile Options

[gmeluski]

Not a rubyist but it looks like the the name is being populated in config/locales/en, which is utilized in the profile template called in the info window controller

Not obvious to me how name gets in there, guessing that it might be in a global(ish) scope

EDIT: Never mind looks like name comes as part of @thing: https://github.com/Code4HR/adopt-a-drain/blob/master/app/views/users/profile.html.haml#L4