Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Update view when drain is adopted #30

Open
ryayak1460 opened this issue Dec 3, 2017 · 4 comments
Open

Update view when drain is adopted #30

ryayak1460 opened this issue Dec 3, 2017 · 4 comments
Assignees

Comments

@ryayak1460
Copy link
Collaborator

ryayak1460 commented Dec 3, 2017

As a User, when I adopt a drain the screen is not updated and I don't know that something has happened.

If I refresh the page I can see the change.

Update the popup and the list.

Same issue as CityOfVirginiaBeach#8

@ryayak1460
Copy link
Collaborator Author

ryayak1460 commented Dec 3, 2017

I see a 500 error in production when adopting a drain, but not in development.

Since the given response (a 500 response with an error object) does not match what the things controller update method can render (a 500 response with a json.errors object), the issue seems to stem from the mailing methods, especially since after the second adoption, we don't send a third email and the third adoption works, according to @kmcurry here.

I also noticed that in production we use the environment variables SENDGRID_USERNAME, SENDGRID_PASSWORD and SENDGRID_DOMAIN when configuring the mailer. How could we get those to the Ruby container?

P.S.: Tagged @BretFisher because I don't know the best way to go about this with our current pipeline and wanted some guidance.

@BretFisher
Copy link
Member

BretFisher commented Dec 3, 2017

Does it happen in our new autobuild of develop branch? https://norfolkdrains-develop.herokuapp.com/

Let me invite you to Heroku and see if you can take a look there.

@ryayak1460
Copy link
Collaborator Author

I can't test on the develop branch at the moment because the Google Maps API key doesn't recognise the norfolkdrains-develop.herokuapp.com domain, so we may have to get that situated first.

@BretFisher
Copy link
Member

Right, we need @kmcurry to update the api key to include that 2nd url (if that's allowed on maps api keys)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants