Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement std::fmt::Display for Query #146

Open
slvrtrn opened this issue Sep 10, 2024 · 0 comments · May be fixed by #155
Open

Implement std::fmt::Display for Query #146

slvrtrn opened this issue Sep 10, 2024 · 0 comments · May be fixed by #155
Labels
enhancement New feature or request

Comments

@slvrtrn
Copy link
Contributor

slvrtrn commented Sep 10, 2024

It might be helpful to log the queries.
Currently, it is not possible:

error[E0277]: `Query` doesn't implement `std::fmt::Display`
  |
8 |     println!("{query}");
  |               ^^^^^^^ `Query` cannot be formatted with the default formatter
  |
  = help: the trait `std::fmt::Display` is not implemented for `Query`

The current implementation of SQLBuilder moves mut self, so it looks like some refactoring will be required there.

@slvrtrn slvrtrn added the enhancement New feature or request label Sep 10, 2024
@pravic pravic linked a pull request Sep 18, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant