Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MoM Blink spell actually generates the random number instead of describing the number as random #76298

Open
dev-dsp opened this issue Sep 8, 2024 · 4 comments · May be fixed by #76513
Open

MoM Blink spell actually generates the random number instead of describing the number as random #76298

dev-dsp opened this issue Sep 8, 2024 · 4 comments · May be fixed by #76513
Labels
Mods: Mind Over Matter (S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@dev-dsp
Copy link

dev-dsp commented Sep 8, 2024

Describe the bug

cdda-2024-09-09_03.55.37.webm

Attach save file

Nairn-trimmed.tar.gz

Steps to reproduce

  1. Open spellcasting menu
  2. Scroll to Blink

Expected behavior

Good old static numbers

Screenshots

No response

Versions and configuration

  • OS: Linux
    • OS Version: LSB Version: n/a; Distributor ID: Gentoo; Description: Gentoo Linux; Release: 2.15; Codename: n/a;
  • Game Version: cdda-experimental-2024-09-08-2121 515ac7b [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth],
    Mind Over Matter [mindovermatter],
    Stats Through Kills [stats_through_kills],
    SpeedyDex [speedydex]
    ]

Additional context

No response
@dev-dsp dev-dsp added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Sep 8, 2024
@Standing-Storm
Copy link
Contributor

Blink has RANDOM_AOE--that might be the reason for this.

@db48x
Copy link
Contributor

db48x commented Sep 13, 2024

Yes, the problem is that the code that generates the description of the spell actually generates the random number instead of describing the number as random. Currently the menu recreates the description on every frame, which is itself a bug (and one that will be fixed elsewhere), and thus the number changes every time the window is updated.

Since I’m already in the process of fixing the other bug, why don’t you change the title of this bug to something more specific about the spell description. Both bugs need to be fixed, and it would be a shame to forget about it once the menu no longer shows the description changing every frame.

@dev-dsp dev-dsp changed the title MoM Blink acts funny MoM Blink spell actually generates the random number instead of describing the number as random Sep 13, 2024
@dev-dsp
Copy link
Author

dev-dsp commented Sep 15, 2024

@db48x does this need confirmation label then?

@db48x
Copy link
Contributor

db48x commented Sep 15, 2024

The bug definitely exists, but I can’t edit labels myself or I would already have confirmed it.

@db48x db48x linked a pull request Sep 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Mods: Mind Over Matter (S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement a better way to wrap text containing color tags db48x/Cataclysm-DDA
4 participants
@db48x @dev-dsp @RenechCDDA @Standing-Storm