Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain-specific site names need to be editable and translatable #15

Open
MarttiR opened this issue May 16, 2017 · 0 comments
Open

Domain-specific site names need to be editable and translatable #15

MarttiR opened this issue May 16, 2017 · 0 comments

Comments

@MarttiR
Copy link
Contributor

MarttiR commented May 16, 2017

1 ) Currently, domain- and language-specific site names are set to be overridden by the name of the domain. This has been done by exporting the variable domain_sitename_override=true to the Domains feature.

This means we can't have translatable site names like "City of Kada" <--> "Kadan kaupunki" because the site name and thus part of the page title is overridden to the name of the domain, "Kada.fi".

There doesn't seem to be a reason to enforce this setting across the whole platform; multilingual domain site names seem to be working just fine without the override setting enabled.

Thus, the domain_sitename_override variable should be removed from the Domains feature so changing the setting on KADA installations will not leave the feature unnecessarily overridden, as that would require a separate feature override to be generated for it for every separate installation.

2 ) Elsewhere in the code, hooks are used to override various titles, e.g. titles in http://www.turku.fi/term/77/rss.xml, and these hooks hardcode installation-dependent strings. See e.g. kada_export_feature_views_pre_render() in kada_export_feature.module.

Instead of replacing the hardcoded "Turku.fi" with a hardcoded dummy domain, we should use the multilingual domain variable site_name to construct titles.

Thus, to avoid having to override the same things at every installation, we need to refactor to remove hardcoding as in 2), which can be only be done after removing the override variable as detailed in 1).

But, is there something that's being overlooked here? Custom domain-handling code should be using domain machine names and never need to touch domain variables anyway, so things should be safe on that front.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant