diff --git a/grade/grading/form/rubric/lang/en/gradingform_rubric.php b/grade/grading/form/rubric/lang/en/gradingform_rubric.php
index 5fb170ab708c7..766960a8bf8de 100644
--- a/grade/grading/form/rubric/lang/en/gradingform_rubric.php
+++ b/grade/grading/form/rubric/lang/en/gradingform_rubric.php
@@ -72,6 +72,7 @@
$string['regradeoption0'] = 'Do not mark for regrade';
$string['regradeoption1'] = 'Mark for regrade';
$string['restoredfromdraft'] = 'NOTE: The last attempt to grade this person was not saved properly so draft grades have been restored. If you want to cancel these changes use the \'Cancel\' button below.';
+$string['remark'] = '{$a} remark';
$string['rubric'] = 'Rubric';
$string['rubricmapping'] = 'Score to grade mapping rules';
$string['rubricmappingexplained'] = 'The minimum possible score for this rubric is {$a->minscore} points. It will be converted to the minimum grade available for the activity (which is 0 unless a scale is used). The maximum score of {$a->maxscore} points will be converted to the maximum grade. Intermediate scores will be converted respectively.
diff --git a/grade/grading/form/rubric/templates/grades/grader/gradingpanel.mustache b/grade/grading/form/rubric/templates/grades/grader/gradingpanel.mustache
index 56a495e018d9f..c491a8163346b 100644
--- a/grade/grading/form/rubric/templates/grades/grader/gradingpanel.mustache
+++ b/grade/grading/form/rubric/templates/grades/grader/gradingpanel.mustache
@@ -85,12 +85,10 @@
id="advancedgrading-criteria-{{criterionid}}-levels-{{id}}-definition"
value="{{id}}"
{{#checked}}
- aria-checked="true"
tabindex="0"
checked
{{/checked}}
{{^checked}}
- aria-checked="false"
tabindex="-1"
{{/checked}}
>
@@ -107,6 +105,7 @@
@@ -94,6 +94,7 @@
aria-haspopup="true"
aria-expanded="false"
aria-label="{{#str}} actionsforgraderinterface, mod_forum {{/str}}"
+ data-action="togglefullscreen"
>
{{#pix}} i/menu, core {{/pix}}
@@ -102,7 +103,6 @@
class="dropdown-item"
type="button"
data-action="togglefullscreen"
- type="button"
>
{{#str}} togglefullscreen, mod_forum {{/str}}
diff --git a/mod/forum/tests/behat/forum_activity_completion.feature b/mod/forum/tests/behat/forum_activity_completion.feature
index 1b566755ab148..9ff5166b9badc 100644
--- a/mod/forum/tests/behat/forum_activity_completion.feature
+++ b/mod/forum/tests/behat/forum_activity_completion.feature
@@ -78,7 +78,8 @@ Feature: View activity completion in the forum activity
And I press "Grade users"
And I set the field "grade" to "33"
And I press "Save"
- And I press "Close grader"
+ And I click on "Close grader" "button" in the "Forum grader" "Fullscreen interface"
+ And I log out
# All conditions should now be completed.
When I am on the "Music history" "forum activity" page logged in as student1
Then the "View" completion condition of "Music history" is displayed as "done"
diff --git a/mod/forum/tests/behat/forum_activity_completion_pass_grade.feature b/mod/forum/tests/behat/forum_activity_completion_pass_grade.feature
index 9e9f4e613d24c..ba62a24a53591 100644
--- a/mod/forum/tests/behat/forum_activity_completion_pass_grade.feature
+++ b/mod/forum/tests/behat/forum_activity_completion_pass_grade.feature
@@ -1,5 +1,5 @@
@mod @mod_forum @core_completion
-Feature: Completion pass grade view activity completion in the forum activity
+Feature: Completion pass grade view activity completion in the forum activity
In order to have visibility of forum completion requirements
As a student
I need to be able to view my forum completion progress
@@ -82,7 +82,8 @@ Feature: Completion pass grade view activity completion in the forum activity
And I press "Grade users"
And I set the field "grade" to "33"
And I press "Save"
- And I press "Close grader"
+ And I click on "Close grader" "button" in the "Forum grader" "Fullscreen interface"
+ And I log out
# All conditions should now be completed.
When I am on the "Music history" "forum activity" page logged in as student1
Then the "View" completion condition of "Music history" is displayed as "done"
@@ -126,7 +127,8 @@ Feature: Completion pass grade view activity completion in the forum activity
And I press "Grade users"
And I set the field "grade" to "60"
And I press "Save"
- And I press "Close grader"
+ And I click on "Close grader" "button" in the "Forum grader" "Fullscreen interface"
+ And I log out
# All conditions should now be completed.
When I am on the "Music history" "forum activity" page logged in as student1
Then the "View" completion condition of "Music history" is displayed as "done"
diff --git a/mod/forum/tests/behat/forum_grading_interface.feature b/mod/forum/tests/behat/forum_grading_interface.feature
new file mode 100644
index 0000000000000..40c6dae189ac4
--- /dev/null
+++ b/mod/forum/tests/behat/forum_grading_interface.feature
@@ -0,0 +1,117 @@
+@mod @mod_forum @core_grades @javascript @mod_forum_grading
+Feature: I can set up & perform basic operations
+ with the forum grading interface, whilst manually confirming
+ required fields exist.
+
+ Background:
+ Given the following "users" exist:
+ | username | firstname | lastname | email |
+ | teacher1 | Teacher | 1 | teacher1@example.com |
+ | student1 | Student | 1 | student1@example.com |
+ | student2 | Student | 2 | student2@example.com |
+ And the following "courses" exist:
+ | fullname | shortname | format | numsections |
+ | Course 1 | C1 | weeks | 5 |
+ And the following "grade categories" exist:
+ | fullname | course |
+ | Tutor | C1 |
+ | Peers | C1 |
+ And the following "course enrolments" exist:
+ | user | course | role |
+ | teacher1 | C1 | editingteacher |
+ | student1 | C1 | student |
+ | student2 | C1 | student |
+ And the following "activities" exist:
+ | activity | course | name |
+ | forum | C1 | Test Forum 1 |
+ And I am on the "Test Forum 1" "forum activity editing" page logged in as teacher1
+ And I set the following fields to these values:
+ | grade_forum[modgrade_type] | Point |
+ | grade_forum[modgrade_point] | 10 |
+ | gradecat_forum | Tutor |
+ | gradepass_forum | 4 |
+ | advancedgradingmethod_forum | Simple direct grading |
+ And I press "Save and display"
+ And I change window size to "large"
+
+ Scenario: Test setting up forum grading and test some of the basic functionality.
+ Given I click on "Grade users" "button"
+ # Breadcrumb items
+ And I should see "C1"
+ And I should see "Test Forum 1"
+ And I should see "Grading"
+ # Check that we have the grading panel
+ And I should see "Grading (Test Forum 1)"
+ # Close the grader interface back to the course
+ And I click on "C1" "link" in the "Forum grader" "Fullscreen interface"
+ And I wait to be redirected
+ And I should see "Course 1"
+ And I follow "Test Forum 1"
+ And I click on "Grade users" "button"
+ # Close the grader interface back to the forum / Waits in place till event handlers moved
+ And I click on "Test Forum 1" "link" in the "Forum grader" "Fullscreen interface"
+ And I should not see "Grading (Test Forum 1)"
+ And I click on "Grade users" "button"
+ And I should see "Grading (Test Forum 1)"
+ And I click on "Close grader" "button" in the "Forum grader" "Fullscreen interface"
+ And I should not see "Grading (Test Forum 1)"
+ And I click on "Grade users" "button"
+ # Collapse the grading panel
+ And I should see "Grading (Test Forum 1)"
+ And I click on "Hide grader panel" "button"
+ And I should not see "Grading (Test Forum 1)"
+ And I click on "Show grader panel" "button"
+ And I should see "Grading (Test Forum 1)"
+ # Navigate between users. / Could add graded status when it is rolled in
+ And I should see "Student 1"
+ And I should see "1 out of 2"
+ And I set the field "Grade" to "6"
+ And I click on "Save changes and proceed to the next user" "button"
+ And I should see "Student 2"
+ And I should not see "1 out of 2"
+ And I click on "Save changes and proceed to the previous user" "button"
+ And I should see "Student 1"
+ And I should not see "2 out of 2"
+ And the field "Grade" matches value "6"
+ # Search for a user
+ And I click on "Search users" "button" in the "Forum grader" "Fullscreen interface"
+ And I click on "Student 2" "button"
+ And I should see "Student 2"
+ And I should see "2 out of 2"
+ And I click on "Search users" "button" in the "Forum grader" "Fullscreen interface"
+ And I click on "Student 1" "button"
+ And I should see "Student 1"
+ And I should see "1 out of 2"
+ # Forum discussions
+ And I am on "Course 1" course homepage
+ And I add a new discussion to "Test Forum 1" forum with:
+ | Subject | Photosynthesis discussion |
+ | Message | Lets discuss our learning about Photosynthesis this week in this thread. |
+ And I log out
+ And I am on the "C1" "Course" page logged in as "student1"
+ And I reply "Photosynthesis discussion" post from "Test Forum 1" forum with:
+ | Message | Can anyone tell me which number is the mass number in the periodic table? |
+ And I log out
+ And I am on the "C1" "Course" page logged in as "student2"
+ And I reply "Photosynthesis discussion" post from "Test Forum 1" forum with:
+ | Message | What does Photosynthesis mean? |
+ And I log out
+ And I am on the "C1" "Course" page logged in as "teacher1"
+ And I click on "Test Forum 1" "link"
+ And I click on "Grade users" "button"
+ # Parent post
+ And I should see "Discussion started by Teacher 1"
+ And I should see "Photosynthesis discussion"
+ And I should see "View parent post"
+ And I click on "View parent post" "button"
+ And I should see "Lets discuss our learning about Photosynthesis this week in this thread."
+ # User post
+ And I should see "Re: Photosynthesis discussion"
+ And I should see "by Student 1"
+ And I should see "Can anyone tell me which number is the mass number in the periodic table?"
+ And I should see "View discussion"
+ # View post in context
+ And I click on "View discussion" "button"
+ And I should see "Photosynthesis discussion"
+ And I should see "by Student 2"
+ And I should see "What does Photosynthesis mean?"
diff --git a/mod/forum/tests/behat/forum_grading_interface_marking_guide.feature b/mod/forum/tests/behat/forum_grading_interface_marking_guide.feature
new file mode 100644
index 0000000000000..4bc595fc56b80
--- /dev/null
+++ b/mod/forum/tests/behat/forum_grading_interface_marking_guide.feature
@@ -0,0 +1,85 @@
+@mod @mod_forum @core_grades @javascript @mod_forum_grading
+Feature: I can grade a students interaction across a marking guide forum
+ As a teacher using the grading interface
+ I can assign grades to a student based on their contributions
+ Using Marking Guide based advanced grading guide
+
+ Background:
+ Given the following "users" exist:
+ | username | firstname | lastname | email |
+ | teacher1 | Teacher | 1 | teacher1@example.com |
+ | student1 | Student | 1 | student1@example.com |
+ | student2 | Student | 2 | student2@example.com |
+ And the following "courses" exist:
+ | fullname | shortname | format | numsections |
+ | Course 1 | C1 | weeks | 5 |
+ And the following "grade categories" exist:
+ | fullname | course |
+ | Tutor | C1 |
+ | Peers | C1 |
+ And the following "course enrolments" exist:
+ | user | course | role |
+ | teacher1 | C1 | editingteacher |
+ | student1 | C1 | student |
+ | student2 | C1 | student |
+ And the following "activities" exist:
+ | activity | course | name |
+ | forum | C1 | Marking Guide Forum |
+ And I am on the "Marking Guide Forum" "forum activity editing" page logged in as teacher1
+ And I set the following fields to these values:
+ | grade_forum[modgrade_type] | Point |
+ | grade_forum[modgrade_point] | 100 |
+ | gradecat_forum | Tutor |
+ | gradepass_forum | 70 |
+ | advancedgradingmethod_forum | Marking guide |
+ And I press "Save and display"
+ And I change window size to "large"
+
+ Scenario: Confirm as a teacher I can use a marking guide.
+ # Defining a marking guide
+ Given I go to "Marking Guide Forum" advanced grading definition page
+ And I set the following fields to these values:
+ | Name | Forum marking guide |
+ | Description | Marking guide test description |
+ And I define the following marking guide:
+ | Criterion name | Description for students | Description for markers | Maximum score |
+ | Guide criterion A | Guide A description for students | Guide A description for markers | 30 |
+ | Guide criterion B | Guide B description for students | Guide B description for markers | 30 |
+ | Guide criterion C | Guide C description for students | Guide C description for markers | 40 |
+ And I define the following frequently used comments:
+ | Comment 1 |
+ | Comment 2 |
+ | Comment 3 |
+ | Comment "4" |
+ When I press "Save marking guide and make it ready"
+ Then I should see "Ready for use"
+ And I should see "Guide criterion A"
+ And I should see "Guide criterion B"
+ And I should see "Guide criterion C"
+ And I should see "Comment 1"
+ And I should see "Comment 2"
+ And I should see "Comment 3"
+ And I should see "Comment \"4\""
+ And I navigate to "Forum" in current page administration
+ # Open the grader interface.
+ And I click on "Grade users" "button"
+ And I wait until "Student 1" "text" exists
+ # Xpaths used to get around the name needing to be a very specific dynamic name.
+ And I set the field with xpath "//input[contains(@aria-label,'Guide criterion A score')]" to "25"
+ And I set the field with xpath "//textarea[contains(@aria-label,'Additional comments for criterion, Guide criterion A')]" to "Very good"
+ And I set the field with xpath "//input[contains(@aria-label,'Guide criterion B score')]" to "20"
+ And I set the field with xpath "//input[contains(@aria-label,'Guide criterion C score')]" to "35"
+ And I set the field with xpath "//textarea[contains(@aria-label,'Additional comments for criterion, Guide criterion C')]" to "Nice!"
+ And I click on "Save changes and proceed to the next user" "button"
+ And the field with xpath "//textarea[contains(@aria-label,'Additional comments for criterion, Guide criterion A')]" does not match value "Very good"
+ And I click on "Save changes and proceed to the previous user" "button"
+ And I wait until "Student 1" "text" exists
+ And the field with xpath "//textarea[contains(@aria-label,'Additional comments for criterion, Guide criterion A')]" matches value "Very good"
+ # Confirm the grade is now in the grading report.
+ And I am on "Course 1" course homepage
+ And I navigate to "View > User report" in the course gradebook
+ And I click on "Student 1" in the "user" search widget
+ And the following should exist in the "user-grade" table:
+ | Grade item | Calculated weight | Grade | Range | Percentage | Contribution to course total |
+ | Marking Guide Forum whole forum | 100.00 % | 80 | 0–100 | 80.00 % | 80.00 % |
+ | Course total | - | 80.00 | 0–100 | 80.00 % | - |
diff --git a/mod/forum/tests/behat/forum_grading_interface_point.feature b/mod/forum/tests/behat/forum_grading_interface_point.feature
new file mode 100644
index 0000000000000..d22d378ffc249
--- /dev/null
+++ b/mod/forum/tests/behat/forum_grading_interface_point.feature
@@ -0,0 +1,57 @@
+@mod @mod_forum @core_grades @javascript @mod_forum_grading
+Feature: I can grade a students interaction across a basic point based forum
+ As a teacher using the grading interface
+ I can assign grades to a student based on their contributions
+ Using point based simple grading
+
+ Background:
+ Given the following "users" exist:
+ | username | firstname | lastname | email |
+ | teacher1 | Teacher | 1 | teacher1@example.com |
+ | student1 | Student | 1 | student1@example.com |
+ | student2 | Student | 2 | student2@example.com |
+ And the following "courses" exist:
+ | fullname | shortname | format | numsections |
+ | Course 1 | C1 | weeks | 5 |
+ And the following "grade categories" exist:
+ | fullname | course |
+ | Tutor | C1 |
+ | Peers | C1 |
+ And the following "course enrolments" exist:
+ | user | course | role |
+ | teacher1 | C1 | editingteacher |
+ | student1 | C1 | student |
+ | student2 | C1 | student |
+ And the following "activities" exist:
+ | activity | course | name |
+ | forum | C1 | Point Forum |
+ And I am on the "Point Forum" "forum activity editing" page logged in as teacher1
+ And I set the following fields to these values:
+ | grade_forum[modgrade_type] | Point |
+ | grade_forum[modgrade_point] | 10 |
+ | gradecat_forum | Tutor |
+ | gradepass_forum | 4 |
+ | advancedgradingmethod_forum | Simple direct grading |
+ And I press "Save and display"
+ And I change window size to "large"
+
+ Scenario: Grade a forum using point marking.
+ # Open the grader interface.
+ Given I click on "Grade users" "button"
+ And I should see "Grading (Point Forum)"
+ When I set the field "grade" to "6"
+ # Save the grade & Check it shows on user navigation
+ And I click on "Save changes and proceed to the next user" "button"
+ And I should see "Student 2"
+ And the field "grade" does not match value "6"
+ And I click on "Save changes and proceed to the previous user" "button"
+ And I should see "Student 1"
+ And the field "grade" matches value "6"
+ # Confirm the grade is now in the grading report.
+ And I am on "Course 1" course homepage
+ And I navigate to "View > User report" in the course gradebook
+ And I click on "Student 1" in the "user" search widget
+ Then the following should exist in the "user-grade" table:
+ | Grade item | Calculated weight | Grade | Range | Percentage | Contribution to course total |
+ | Point Forum whole forum | 100.00 % | 6.00 | 0–10 | 60.00 % | 60.00 % |
+ | Course total | - | 6.00 | 0–10 | 60.00 % | - |
diff --git a/mod/forum/tests/behat/forum_grading_interface_rubric.feature b/mod/forum/tests/behat/forum_grading_interface_rubric.feature
new file mode 100644
index 0000000000000..73f0d2a4d92a5
--- /dev/null
+++ b/mod/forum/tests/behat/forum_grading_interface_rubric.feature
@@ -0,0 +1,76 @@
+@mod @mod_forum @core_grades @javascript @mod_forum_grading
+Feature: I can grade a students interaction across a rubric forum
+ As a teacher using the grading interface
+ I can assign grades to a student based on their contributions
+ Using rubric based advanced grading rubric
+
+ Background:
+ Given the following "users" exist:
+ | username | firstname | lastname | email |
+ | teacher1 | Teacher | 1 | teacher1@example.com |
+ | student1 | Student | 1 | student1@example.com |
+ | student2 | Student | 2 | student2@example.com |
+ And the following "courses" exist:
+ | fullname | shortname | format | numsections |
+ | Course 1 | C1 | weeks | 5 |
+ And the following "grade categories" exist:
+ | fullname | course |
+ | Tutor | C1 |
+ | Peers | C1 |
+ And the following "course enrolments" exist:
+ | user | course | role |
+ | teacher1 | C1 | editingteacher |
+ | student1 | C1 | student |
+ | student2 | C1 | student |
+ And the following "activities" exist:
+ | activity | course | name |
+ | forum | C1 | Rubric Forum |
+ And I am on the "Rubric Forum" "forum activity editing" page logged in as teacher1
+ And I set the following fields to these values:
+ | grade_forum[modgrade_type] | Point |
+ | grade_forum[modgrade_point] | 100 |
+ | gradecat_forum | Tutor |
+ | gradepass_forum | 70 |
+ | advancedgradingmethod_forum | Rubric |
+ And I press "Save and display"
+ And I change window size to "large"
+
+ Scenario: Confirm as a teacher I can grade using a rubric.
+ Given I go to "Rubric Forum" advanced grading definition page
+ # Defining a rubric.
+ And I set the following fields to these values:
+ | Name | Rubric Forum rubric |
+ | Description | Rubric test description |
+ And I define the following rubric:
+ | Criterion 1 | Level 11 | 1 | Level 12 | 20 | Level 13 | 40 | Level 14 | 50 |
+ | Criterion 2 | Level 21 | 10 | Level 22 | 20 | Level 23 | 30 | | |
+ | Criterion 3 | Level 31 | 5 | Level 32 | 20 | | | | |
+ And I press "Save as draft"
+ And I go to "Rubric Forum" advanced grading definition page
+ When I press "Save rubric and make it ready"
+ Then I should see "Ready for use"
+ And I click on "Rubric Forum" "link"
+ # Open the grader interface.
+ And I click on "Grade users" "button"
+ And I wait until "Student 1" "text" exists
+ And I click on "Level 14" "radio"
+ And I click on "Level 21" "radio"
+ And I click on "Level 31" "radio"
+ # Xpaths used to get around the name needing to be a very specific dynamic name.
+ And I set the field with xpath "//textarea[contains(@aria-label,'Criterion 1 remark')]" to "Well done"
+ And I set the field with xpath "//textarea[contains(@aria-label,'Criterion 2 remark')]" to "Nice effort"
+ And I set the field with xpath "//textarea[contains(@aria-label,'Criterion 3 remark')]" to "A lot of room to grow"
+ And I click on "Save changes and proceed to the next user" "button"
+ And I wait until "Student 2" "text" exists
+ And the field with xpath "//textarea[contains(@aria-label,'Criterion 1 remark')]" does not match value "Well done"
+ And I click on "Save changes and proceed to the previous user" "button"
+ And I wait until "Student 1" "text" exists
+ And the field with xpath "//textarea[contains(@aria-label,'Criterion 1 remark')]" matches value "Well done"
+ # Confirm the grade is now in the grading report.
+ And I am on "Course 1" course homepage
+ And I navigate to "View > User report" in the course gradebook
+ And I click on "Student 1" in the "user" search widget
+ And the following should exist in the "user-grade" table:
+ | Grade item | Calculated weight | Grade | Range | Percentage | Contribution to course total |
+ | Rubric Forum whole forum | 100.00 % | 65.00 | 0–100 | 65.00 % | 65.00 % |
+ | Course total | - | 65.00 | 0–100 | 65.00 % | - |
diff --git a/mod/forum/tests/behat/forum_grading_interface_scale.feature b/mod/forum/tests/behat/forum_grading_interface_scale.feature
new file mode 100644
index 0000000000000..d1aded380af12
--- /dev/null
+++ b/mod/forum/tests/behat/forum_grading_interface_scale.feature
@@ -0,0 +1,60 @@
+@mod @mod_forum @core_grades @javascript @mod_forum_grading
+Feature: I can grade a students interaction across a scale forum
+ As a teacher using the grading interface
+ I can assign grades to a student based on their contributions
+ Using scale based simple grading
+
+ Background:
+ Given the following "users" exist:
+ | username | firstname | lastname | email |
+ | teacher1 | Teacher | 1 | teacher1@example.com |
+ | student1 | Student | 1 | student1@example.com |
+ | student2 | Student | 2 | student2@example.com |
+ And the following "courses" exist:
+ | fullname | shortname | format | numsections |
+ | Course 1 | C1 | weeks | 5 |
+ And the following "grade categories" exist:
+ | fullname | course |
+ | Tutor | C1 |
+ | Peers | C1 |
+ And the following "course enrolments" exist:
+ | user | course | role |
+ | teacher1 | C1 | editingteacher |
+ | student1 | C1 | student |
+ | student2 | C1 | student |
+ And the following "scales" exist:
+ | name | scale |
+ | Test Scale 1 | Disappointing, Good, Very good, Excellent |
+ And the following "activities" exist:
+ | activity | course | name |
+ | forum | C1 | Scale Forum |
+ And I am on the "Scale Forum" "forum activity editing" page logged in as teacher1
+ And I set the following fields to these values:
+ | grade_forum[modgrade_type] | Scale |
+ | grade_forum[modgrade_scale] | Test Scale 1 |
+ | gradecat_forum | Tutor |
+ | gradepass_forum | 2 |
+ | advancedgradingmethod_forum | Simple direct grading |
+ And I press "Save and display"
+ And I change window size to "large"
+
+ Scenario: Grade a learners activity using a scale.
+ # Open the grader interface.
+ Given I click on "Grade users" "button"
+ And I should see "Grading (Scale Forum)"
+ When I set the field "Grade" to "Very good"
+ # Save the grade & Check it shows on user navigation
+ And I click on "Save changes and proceed to the next user" "button"
+ And I should see "Student 2"
+ And the field "Grade" does not match value "Very good"
+ And I click on "Save changes and proceed to the previous user" "button"
+ And I should see "Student 1"
+ And the field "Grade" matches value "Very good"
+ # Confirm the grade is now in the grading report.
+ And I am on "Course 1" course homepage
+ And I navigate to "View > User report" in the course gradebook
+ And I click on "Student 1" in the "user" search widget
+ Then the following should exist in the "user-grade" table:
+ | Grade item | Calculated weight | Grade | Range | Percentage | Contribution to course total |
+ | Scale Forum whole forum | 100.00 % | Very good | Disappointing–Excellent | 66.67 % | 75.00 % |
+ | Course total | - | 3.00 | 0–4 | 75.00 % | - |
diff --git a/mod/forum/tests/behat/grade_view_discussion.feature b/mod/forum/tests/behat/grade_view_discussion.feature
index eaf1a18f018d6..7ccc245f4fbc6 100644
--- a/mod/forum/tests/behat/grade_view_discussion.feature
+++ b/mod/forum/tests/behat/grade_view_discussion.feature
@@ -27,7 +27,7 @@ Feature: View discussion while grading in a forum
| grade_forum | 100 |
| scale | 100 |
# If there is more than one pots for Student 1 the test will not be able to select the
- # correct View discussion link, as there is no selector for thier container.
+ # correct View discussion link, as there is no selector for their container.
And the following forum discussions exist in course "Course 1":
| forum | user | name | message |
| Gradable forum | student1 | My topic | This is the thing I posted about |
@@ -46,8 +46,7 @@ Feature: View discussion while grading in a forum
Scenario: Viewing a discussion while grading is fullscreen
Given I am on the "Gradable forum" "forum activity" page logged in as teacher
And I press "Grade users"
- # Uses the aria-label for the menu in in the grading interface.
- And I press "Actions for the grader interface"
+ And I click on "Actions for the grader interface" "button" in the "Forum grader" "Fullscreen interface"
And I press "Toggle full screen"
When I press "View discussion"
Then I should see "I disagree" in the "My topic" "dialogue"
diff --git a/theme/boost/scss/moodle/modules.scss b/theme/boost/scss/moodle/modules.scss
index 5ae0c605d82fa..38bb06936d2bb 100644
--- a/theme/boost/scss/moodle/modules.scss
+++ b/theme/boost/scss/moodle/modules.scss
@@ -588,16 +588,16 @@ $grading-content-show-content-button-padding-left: calc(#{map-get($spacers, 2) *
}
.toggle-search-button {
- &.expand {
+ &.expanded {
animation-name: expandSearchButton;
animation-duration: $grading-animation-duration;
animation-timing-function: ease-in-out;
}
- &.collapse {
- display: block;
+ &.collapsed {
animation-name: collapseSearchButton;
animation-duration: $grading-animation-duration;
+ animation-timing-function: ease-in-out;
}
}
@@ -681,7 +681,7 @@ $grading-content-show-content-button-padding-left: calc(#{map-get($spacers, 2) *
}
}
- &.collapsed {
+ &.collapsed-box {
width: calc(#{$grading-icon-button-size} + #{map-get($spacers, 2)} + #{map-get($spacers, 2)});
transition: width $grading-animation-duration ease-in-out;
diff --git a/theme/boost/style/moodle.css b/theme/boost/style/moodle.css
index bba2e639d67df..972b04b41f244 100644
--- a/theme/boost/style/moodle.css
+++ b/theme/boost/style/moodle.css
@@ -33920,15 +33920,15 @@ select {
transition: left 0.3s ease-in-out;
z-index: 1;
}
-.path-mod-forum .unified-grader .grader-grading-panel .header-container .toggle-search-button.expand {
+.path-mod-forum .unified-grader .grader-grading-panel .header-container .toggle-search-button.expanded {
animation-name: expandSearchButton;
animation-duration: 0.3s;
animation-timing-function: ease-in-out;
}
-.path-mod-forum .unified-grader .grader-grading-panel .header-container .toggle-search-button.collapse {
- display: block;
+.path-mod-forum .unified-grader .grader-grading-panel .header-container .toggle-search-button.collapsed {
animation-name: collapseSearchButton;
animation-duration: 0.3s;
+ animation-timing-function: ease-in-out;
}
.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container {
overflow: hidden;
@@ -33992,24 +33992,24 @@ select {
overflow: hidden;
transition: opacity 0s linear 0.3s, max-height 0s linear 0.3s, max-width 0s linear 0.3s, visibility 0s linear 0.3s;
}
-.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed {
+.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed-box {
width: calc(36px + 0.5rem + 0.5rem);
transition: width 0.3s ease-in-out;
}
-.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed .search-input-container {
+.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed-box .search-input-container {
flex-wrap: nowrap;
}
-.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed .search-input-container input,
-.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed .search-input-container .search-icon {
+.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed-box .search-input-container input,
+.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed-box .search-input-container .search-icon {
opacity: 0;
visibility: hidden;
transition: opacity 0s linear, visibility 0s linear;
}
-.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed .search-input-container input {
+.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed-box .search-input-container input {
padding-left: 0;
padding-right: 0;
}
-.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed .search-input-container .toggle-search-button .expanded-icon {
+.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed-box .search-input-container .toggle-search-button .expanded-icon {
opacity: 0;
visibility: hidden;
max-height: 0;
@@ -34017,7 +34017,7 @@ select {
overflow: hidden;
transition: opacity 0s linear, max-height 0s linear, max-width 0s linear, visibility 0s linear;
}
-.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed .search-input-container .toggle-search-button .collapsed-icon {
+.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed-box .search-input-container .toggle-search-button .collapsed-icon {
opacity: 1;
visibility: visible;
max-width: 50px;
diff --git a/theme/classic/style/moodle.css b/theme/classic/style/moodle.css
index 6607b1a5b66ca..0bd05a33bed9b 100644
--- a/theme/classic/style/moodle.css
+++ b/theme/classic/style/moodle.css
@@ -33920,15 +33920,15 @@ select {
transition: left 0.3s ease-in-out;
z-index: 1;
}
-.path-mod-forum .unified-grader .grader-grading-panel .header-container .toggle-search-button.expand {
+.path-mod-forum .unified-grader .grader-grading-panel .header-container .toggle-search-button.expanded {
animation-name: expandSearchButton;
animation-duration: 0.3s;
animation-timing-function: ease-in-out;
}
-.path-mod-forum .unified-grader .grader-grading-panel .header-container .toggle-search-button.collapse {
- display: block;
+.path-mod-forum .unified-grader .grader-grading-panel .header-container .toggle-search-button.collapsed {
animation-name: collapseSearchButton;
animation-duration: 0.3s;
+ animation-timing-function: ease-in-out;
}
.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container {
overflow: hidden;
@@ -33992,24 +33992,24 @@ select {
overflow: hidden;
transition: opacity 0s linear 0.3s, max-height 0s linear 0.3s, max-width 0s linear 0.3s, visibility 0s linear 0.3s;
}
-.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed {
+.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed-box {
width: calc(36px + 0.5rem + 0.5rem);
transition: width 0.3s ease-in-out;
}
-.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed .search-input-container {
+.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed-box .search-input-container {
flex-wrap: nowrap;
}
-.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed .search-input-container input,
-.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed .search-input-container .search-icon {
+.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed-box .search-input-container input,
+.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed-box .search-input-container .search-icon {
opacity: 0;
visibility: hidden;
transition: opacity 0s linear, visibility 0s linear;
}
-.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed .search-input-container input {
+.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed-box .search-input-container input {
padding-left: 0;
padding-right: 0;
}
-.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed .search-input-container .toggle-search-button .expanded-icon {
+.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed-box .search-input-container .toggle-search-button .expanded-icon {
opacity: 0;
visibility: hidden;
max-height: 0;
@@ -34017,7 +34017,7 @@ select {
overflow: hidden;
transition: opacity 0s linear, max-height 0s linear, max-width 0s linear, visibility 0s linear;
}
-.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed .search-input-container .toggle-search-button .collapsed-icon {
+.path-mod-forum .unified-grader .grader-grading-panel .header-container .user-search-container.collapsed-box .search-input-container .toggle-search-button .collapsed-icon {
opacity: 1;
visibility: visible;
max-width: 50px;