Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Custom models do not support containing @, such as the claude-3-5-sonnet@20240620 model on Vertex #5315

Open
rxliuli opened this issue Aug 25, 2024 · 11 comments · May be fixed by #5316
Open
Assignees
Labels
bug Something isn't working

Comments

@rxliuli
Copy link

rxliuli commented Aug 25, 2024

📦 部署方式

Vercel

📌 软件版本

2.14.2

💻 系统环境

macOS

📌 系统版本

14.4.1

🌐 浏览器

Chrome

📌 浏览器版本

127.0.6533.122

🐛 问题描述

image image

📷 复现步骤

No response

🚦 期望结果

No response

📝 补充信息

No response

@rxliuli rxliuli added the bug Something isn't working label Aug 25, 2024
@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Title: [Bug] Custom models do not support containing @, such as the claude-3-5-sonnet@20240620 model on Vertex

@rxliuli rxliuli changed the title [Bug] 自定义模型不支持包含 @,例如 Vertex 上的 claude-3-5-sonnet@20240620 模型 [Bug] Custom models do not support containing @, such as the claude-3-5-sonnet@20240620 model on Vertex Aug 25, 2024
@rxliuli rxliuli linked a pull request Aug 25, 2024 that will close this issue
10 tasks
@QAbot-zh
Copy link

我提过类似的 pr,但还没有被合并:
#5243

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


I mentioned a similar PR, but it hasn't been merged yet:
#5243

@rxliuli
Copy link
Author

rxliuli commented Aug 26, 2024

我提过类似的 pr,但还没有被合并: #5243

似乎仅处理了类似 modelName@azure@azure 这种多个 @ 符号的情况,并未处理 modelName@azure 这种情况,例如 claude-3-5-sonnet@20240620,当然可以在后面再添加一个 @vertex 解决,例如 claude-3-5-sonnet@20240620@vertex

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


I mentioned a similar PR, but it hasn't been merged yet: #5243

It seems that it only handles the case of multiple @ symbols like modelName@azure@azure, but does not handle the case of modelName@azure, such as claude-3-5-sonnet@20240620, of course it can be done later Add another @vertex solution, for example claude-3-5-sonnet@20240620@vertex

@QAbot-zh
Copy link

我提过类似的 pr,但还没有被合并: #5243

似乎仅处理了类似 modelName@azure@azure 这种多个 @ 符号的情况,并未处理 modelName@azure 这种情况,例如 claude-3-5-sonnet@20240620,当然可以在后面再添加一个 @vertex 解决,例如 claude-3-5-sonnet@20240620@vertex

不是的,我是把最后一个@后面的部分切成 providerName,剩下部分作为 modelName

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


I mentioned a similar PR, but it hasn't been merged yet: #5243

It seems that it only handles the case of multiple @ symbols like modelName@azure@azure, but does not handle the case of modelName@azure, such as claude-3-5-sonnet@20240620. Of course, it can be used in Add another @vertex later to solve the problem, for example claude-3-5-sonnet@20240620@vertex

No, I cut the part after the last @ into providerName, and the remaining part was used as modelName

@rxliuli
Copy link
Author

rxliuli commented Aug 26, 2024

我提过类似的 pr,但还没有被合并: #5243

似乎仅处理了类似 modelName@azure@azure 这种多个 @ 符号的情况,并未处理 modelName@azure 这种情况,例如 claude-3-5-sonnet@20240620,当然可以在后面再添加一个 @vertex 解决,例如 claude-3-5-sonnet@20240620@vertex

不是的,我是把最后一个@后面的部分切成 providerName,剩下部分作为 modelName

嗯,所以如果模型本身有 @,那么自定义模型必须再使用一个 @ 避免错误分割嘛

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


I mentioned a similar PR, but it hasn't been merged yet: #5243

It seems that it only handles the case of multiple @ symbols like modelName@azure@azure, but does not handle the case of modelName@azure, such as claude-3-5-sonnet@20240620, of course it can Add another @vertex at the end to solve the problem, for example claude-3-5-sonnet@20240620@vertex

No, I cut the part after the last @ into providerName, and the remaining part was used as modelName

Well, so if the model itself has @, then the custom model must use another @ to avoid incorrect segmentation.

@QAbot-zh
Copy link

我提过类似的 pr,但还没有被合并: #5243

似乎仅处理了类似 modelName@azure@azure 这种多个 @ 符号的情况,并未处理 modelName@azure 这种情况,例如 claude-3-5-sonnet@20240620,当然可以在后面再添加一个 @vertex 解决,例如 claude-3-5-sonnet@20240620@vertex

不是的,我是把最后一个@后面的部分切成 providerName,剩下部分作为 modelName

嗯,所以如果模型本身有 @,那么自定义模型必须再使用一个 @ 避免错误分割嘛

哦理解你的意思了,可以根据切出来的 providerName 是否存在来判断要不要切,这样确实更智能一些

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


I mentioned a similar PR, but it hasn't been merged yet: #5243

It seems that it only handles the case of multiple @ symbols like modelName@azure@azure, but does not handle the case of modelName@azure, such as claude-3-5-sonnet@20240620, of course You can add another @vertex later to solve the problem, for example claude-3-5-sonnet@20240620@vertex

No, I cut the part after the last @ into providerName, and the remaining part was used as modelName.

Well, so if the model itself has @, then the custom model must use another @ to avoid incorrect segmentation.

Oh, I understand what you mean. You can judge whether to cut or not based on whether the cut out providerName exists. This is indeed smarter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants