From 0511ddf7b2b3f9c1a6a5e84e356155d53f1fbeda Mon Sep 17 00:00:00 2001
From: Aden Krakman <akrakman@gmail.com>
Date: Mon, 5 Dec 2022 23:54:17 -0600
Subject: [PATCH] fix oauth since I was setting the username to the email so
 you could never fail logging in

---
 src/backend/app.py            | 12 ++++++------
 src/backend/pages/mainpage.py |  2 --
 src/backend/pages/userpage.py |  2 +-
 3 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/src/backend/app.py b/src/backend/app.py
index 93476c80f..313b4279b 100644
--- a/src/backend/app.py
+++ b/src/backend/app.py
@@ -50,12 +50,12 @@ def authorize():
     resp.raise_for_status()  # check status code
     user_info = resp.json()  # convert to json
     # query database for username and create session
-    page = UserPage(user_info["email"])
-    session["username"] = page.get_user(user_info["email"]).username
-    return (
-        redirect("http://localhost:3000"),
-        301,
-    )  # necessary status code for Flask to auto-redirect
+    get = UserPage("").get_user(user_info["email"])
+    if get.email != "" and get.user_id != "":
+        session["username"] = get.username
+        return redirect("http://localhost:3000"), 301
+    # necessary status code for Flask to auto-redirect
+    return redirect("http://localhost:3000/login"), 301
 
 
 @app.route("/login", methods=["GET", "POST"])
diff --git a/src/backend/pages/mainpage.py b/src/backend/pages/mainpage.py
index f1f8495f0..b7b302291 100644
--- a/src/backend/pages/mainpage.py
+++ b/src/backend/pages/mainpage.py
@@ -284,7 +284,6 @@ def delete_apartment_review(self, apt_id: int, user: str) -> List[Review]:
     def check_user_reviewed(self, apt_id: int, user: str) -> bool:
         """Check if review exists for an user"""
         user_id = self.get_user_id_from_user(user)
-        print(user_id)
         review = self.check_user_reviewed.cursor.execute(
             "SELECT * FROM Reviews WHERE (apt_id = ? AND user_id = ?)",
             (
@@ -292,7 +291,6 @@ def check_user_reviewed(self, apt_id: int, user: str) -> bool:
                 user_id,
             ),
         ).fetchone()
-        print(review)
         return review is not None
 
     @use_database
diff --git a/src/backend/pages/userpage.py b/src/backend/pages/userpage.py
index 44010aaf0..bbadf38c8 100644
--- a/src/backend/pages/userpage.py
+++ b/src/backend/pages/userpage.py
@@ -16,7 +16,7 @@ def __init__(self, name: str) -> None:
 
     @use_database
     def get_user(self, query_sql: str) -> User:
-        """Return User object based on username"""
+        """Return User object based on username or email"""
         user_query = self.get_user.cursor.execute(
             "SELECT u.user_id, u.username, u.password, u.email, u.phone \
             FROM USERS u\