Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

Assignor: Drop the unnecessary params #1069

Open
haozturk opened this issue Sep 6, 2022 · 5 comments
Open

Assignor: Drop the unnecessary params #1069

haozturk opened this issue Sep 6, 2022 · 5 comments

Comments

@haozturk
Copy link
Collaborator

haozturk commented Sep 6, 2022

Impact of the new feature
Assignor

Is your feature request related to a problem? Please describe.
WMCore has dropped some legacy params from workflow dict: dmwm/WMCore#9639 We shouldn't use then in workflow assignment anymore

Describe the solution you'd like
Drop these params in workflow assignment:

custodialSubType, custodialGroup, nonCustodialSubType , autoApproveSites and nonCustodialGroup

@amaltaro please let me know if there is something that i'm missing

Describe alternatives you've considered
None

Additional context
None

@amaltaro
Copy link
Contributor

amaltaro commented Sep 6, 2022

I think this is all that is needed on the Unified side. Sorry for the belated heads up btw!

@haozturk
Copy link
Collaborator Author

haozturk commented Sep 7, 2022

Thanks Alan. We still have workflows being assigned w/ these params. Are they going to have problems?

@amaltaro
Copy link
Contributor

amaltaro commented Sep 7, 2022

If you provide a key/value that is not supported either at creation or workflow assignment, yes it will fail.

@haozturk
Copy link
Collaborator Author

haozturk commented Sep 7, 2022

since when?

I mean since when the 5 params listed above aren't supported?

@haozturk
Copy link
Collaborator Author

haozturk commented Sep 7, 2022

Oh, these are not the exact params. They should start w/ capital letters and it's AutoApproveSubscriptionSites not autoApproveSites. Darn, changing the code again

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants