Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scan reversediff issue #338

Closed
seabbs opened this issue Jul 7, 2024 · 3 comments
Closed

Fix scan reversediff issue #338

seabbs opened this issue Jul 7, 2024 · 3 comments
Labels

Comments

@seabbs
Copy link
Collaborator

seabbs commented Jul 7, 2024

This currently prevents benchmarks being run on Renewal. Any fix should check these and integrate them into the wider benchmarking backend.

# Error: ArgumentError: Converting an instance of ReverseDiff.TrackedReal{Float64, Float64, Nothing} to Float64 is not defined. Please use `ReverseDiff.value` instead.

@SamuelBrand1
Copy link
Collaborator

I'm a bit confused by this one, because if we have hard-typed a variable somewhere as Float64 when ReverseDiff needed to overload as TrackedReal we should have code failure in other areas (e.g. the getting started example(s))

@seabbs
Copy link
Collaborator Author

seabbs commented Jul 8, 2024

Yes its a poser. I haven't inspected the guts of what TuringBenchmarks is doing so perhaps there is some difference vs what we are doing elsewhere.

@seabbs
Copy link
Collaborator Author

seabbs commented Jul 18, 2024

Closing as not doing due to #384

@seabbs seabbs closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants