Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spurious warning for queries with explicit limit < max_limit (ie usually 200,000 rows) #76

Open
jefferis opened this issue Aug 28, 2022 · 0 comments
Open

Spurious warning for queries with explicit limit < max_limit (ie usually 200,000 rows) #76

jefferis opened this issue Aug 28, 2022 · 0 comments

Comments

@jefferis
Copy link

If you specify a limit to restrict the number of rows in a cave query then you always get a spurious warning.

(in R but using CAVEclient)

> fac=flywire_cave_client()
> nuclei_v1=fac$materialize$query_table("nuclei_v1", limit=10L)
201 - "Limited query to 200000 rows
> nrow(nuclei_v1)
[1] 10

I think there is a logic error here
https://github.com/seung-lab/MaterializationEngine/blob/7b6a8b5bacc3b63545aa39462f08fae88bab38d1/materializationengine/blueprints/client/api.py#L550-L551
and the comparison should be to max_limit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jefferis