Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The --output parameter cannot control the file name (additional elements get auto-added so you need to concatenate with mv to actually get the filenames you want...) #143

Open
TheChymera opened this issue Nov 29, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@TheChymera
Copy link

[deco]~ ❱ brkraw -v
brkraw v0.3.10
[deco]~ ❱ brkraw tonii -o lala.nii.gz -s 8 /usr/share/opfvta_brudata/20170411_120358_5682_1_4/
NifTi file is generated... [lala.nii.gz-8-1-TurboRARE]
[deco]~ ❱ stat lala.nii.gz
stat: cannot statx 'lala.nii.gz': No such file or directory
[deco]~ ❱ stat lala.nii.gz-8-1-TurboRARE.nii.gz
  File: lala.nii.gz-8-1-TurboRARE.nii.gz
  Size: 1189539   	Blocks: 2328       IO Block: 4096   regular file
Device: 259,3	Inode: 48067138    Links: 1
Access: (0644/-rw-r--r--)  Uid: ( 1000/ chymera)   Gid: ( 1000/ chymera)
Access: 2023-11-29 12:07:24.191001947 -0500
Modify: 2023-11-29 12:07:24.231002405 -0500
Change: 2023-11-29 12:07:24.231002405 -0500
 Birth: 2023-11-29 12:07:24.191001947 -0500
[deco]~ ❱ brkraw tonii -o lala.nii.gz -s 8 -r 1 /usr/share/opfvta_brudata/20170411_120358_5682_1_4/
NifTi file is generated... [lala.nii.gz-8-1-TurboRARE]
[deco]~ ❱ echo "😢"
😢

--output doesn't actually determine the output name, it's more along the line of --output-basename... I understand that this might be needed if there are multiple files, but if there is only one file it's very awkward to have metadata added to the output filename (and as a suffix after the extension no less...)

Would you be interested in fixing this or accepting a PR to fix it?

@dvm-shlee
Copy link
Member

@TheChymera
Thank you for your feedback. I plan to address this in the upcoming update. Currently, we have a feature that automatically adds scan information to the output file as preferred by researchers, which is why it hasn't been modified yet.

I'm considering introducing two options for the output filename. The --output option could be used to set a specific output filename, while --prefix would set the subject name, with other scan-related information appended to form the full filename, akin to the current behavior of --output.

This change will be implemented in the next update.

@dvm-shlee dvm-shlee self-assigned this Jan 31, 2024
@dvm-shlee dvm-shlee added the bug Something isn't working label Jan 31, 2024
@dvm-shlee dvm-shlee added this to the v0.4.0 release milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants