Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query_type not used in find_overlaps() #43

Open
UriNeri opened this issue Sep 24, 2024 · 1 comment · May be fixed by #44
Open

query_type not used in find_overlaps() #43

UriNeri opened this issue Sep 24, 2024 · 1 comment · May be fixed by #44
Assignees

Comments

@UriNeri
Copy link

UriNeri commented Sep 24, 2024

Hi,

Kudos on bringing these to structures and functionality into python, as a former R dev this can make my life in python much easier!
I noticed that find_overlaps returns all overlap types, ignoring the query_type argument - and it seems the query_type is not passed to the self._generic_find_hits (or would be accepted by it)

def find_overlaps(

I'm not sure if this is a bug or an enhancement request, but posting still.

@jkanche jkanche self-assigned this Sep 24, 2024
@jkanche jkanche linked a pull request Sep 24, 2024 that will close this issue
@jkanche
Copy link
Member

jkanche commented Sep 24, 2024

Thank you for reporting this. probably missed it during implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants