Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rounding error in replaying swap events #53

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Fix rounding error in replaying swap events #53

merged 2 commits into from
Nov 23, 2021

Conversation

kafeikui
Copy link
Contributor

Fix #51

@kafeikui kafeikui added the bug Something isn't working label Nov 22, 2021
@kafeikui kafeikui self-assigned this Nov 22, 2021
@kafeikui kafeikui mentioned this pull request Nov 22, 2021
Open
neptune-v
neptune-v approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@neptune-v neptune-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single comment, the rest LGTM

test/ConfigurableCorePool.test.ts Show resolved Hide resolved
@kafeikui kafeikui merged commit c3bff66 into Bella-DeFinTech:main Nov 23, 2021
@kafeikui kafeikui mentioned this pull request Apr 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neptune-v neptune-v neptune-v approved these changes

Assignees

@kafeikui kafeikui

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How do you handle rounding errors between querySwap and swap?
2 participants
@kafeikui @neptune-v