Lets admins set system clear objectives and refactors extended mission code #2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This didn't actually fix the issue yet
Bokkiewokkie
added
Feature
Fix
Administration
Starsystem
Go get em tigers!!
Bokkiewokkie
changed the title
covertcorvid
requested changes
Sep 21, 2023
covertcorvid
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds the ability for admins to set the target system for a system clearing objective with the overmap gamemode controller.
If you (or most likely the game) for some reason did not select a system, it will instead select a random sector 2 system with enemies in it.
Why It's Good For The Game
This was originally going to be a PR to fix the round extension mission selection system. And while it does technically fix the issue of randomly selected clear missions not functioning, that is still a problem I intend to fix in this PR as well. (Later:) I just made a lazy fix for that now but it should work as originally intended.
Testing Photographs and Procedure
Screenshots&Videos
I did test thisChangelog
🆑
fix: Fixed random clear missions not having a system
refactor: Removed the unintended ability for the mission extension to select any random objective
admin: Made it possible for admins to select a target for the "clear system" objective
/:cl: