Adds a overmap z failsafe #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this point I do not know how we manage to misplace overmap zs all the time, so lets just have a failsafe for if we manage to achieve it!
Bokkiewokkie
added
Fix
Overmap
Bokkiewokkie
previously approved these changes
Aug 19, 2023
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Bokkiewokkie
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Basically, we sometimes have ships with people end up in nullspace that really shouldn't be there.
This adds a failsafe that makes any ship with a certain overmap flag (which all ships that used instance_overmap have), or those with any player inside that might notice, reaquire / create an overmap z if they somehow lose theirs when they arrive at a system.
This should mitigate effects from the variety of things that might cause this to happen (worst case admins should be able to manually trigger the failsafe by using add_ship, if it somehow race conditions and breaks)
Why It's Good For The Game
Fix man good.
Changelog
🆑
fix: Overmap objects with players should be a bit less likely to get stuck in nullspace.
/:cl: