Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VLS unloading fix #2521

Merged
merged 2 commits into from
Sep 21, 2023
Merged

VLS unloading fix #2521

merged 2 commits into from
Sep 21, 2023

Conversation

Ikalpo
Copy link
Contributor

@Ikalpo Ikalpo commented Aug 17, 2023

About The Pull Request

fixes #2337

Brillcrafter brought this to my attention

Why It's Good For The Game

fix man good

Testing Photographs and Procedure

Screenshots&Videos (look they're both here)

image

fun

watch how the variable that's supposed to keep this from happening gets reset during a sleep()

2023-08-17.12-25-05-1.mp4

Changelog

🆑
fix: fixed VLS eating torps that get unloaded
/:cl:

@Brillcrafter
Copy link
Contributor

Brillcrafter commented Aug 17, 2023

oh and don't forget that the variable that was supposed to stop this was doing absolutely nothing. once the oldloc check was put in place, they did absolutely nothing

Copy link
Contributor

@Bokkiewokkie Bokkiewokkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually made autoloading worse intentionally to make manual loading have a benefit. So you can autoload the first missile and then manually do the second if you want more bang for your buck.
If you want double autoloading I suggest making it a researchable or purchasable upgrade.

@Ikalpo Ikalpo changed the title VLS unloading fix + small upgrade VLS unloading fix Aug 18, 2023
@Bokkiewokkie Bokkiewokkie added Active Test Merge Munitions Issues and pull requests related to munitions. labels Aug 25, 2023
@Bokkiewokkie Bokkiewokkie merged commit 890eb46 into BeeStation:master Sep 21, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Active Test Merge Fix Munitions Issues and pull requests related to munitions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missiles/Torps disappear when unloaded from VLS
3 participants