Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atlas Atmospherics Rebuild #2498

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Conversation

SerynEngi
Copy link
Contributor

About The Pull Request

This PR rebuilds Atlas's atmospherics to comply with the standard reactor mixer piping layout and simplifies the layout for understanding.

Why It's Good For The Game

The rebuilt atmos complies with the standard O2/N2/CO2/N20/Constricted Plasma layout present on other ships, and greatly simplifies the piping in atmospherics on the atlas, allowing for greater adaptation and usage of the space.

Testing Photographs and Procedure

AtlasAtmosBeforeAfter

Changelog

🆑
tweak: Rebuild Atlas atmospherics for ease of use.
/:cl:

@Brillcrafter
Copy link
Contributor

Oh god, this means that I will have to update the wiki page if this is permanently merged. Fun

@BlueHNT
Copy link
Contributor

BlueHNT commented Aug 4, 2023

Oh god, this means that I will have to update the wiki page if this is permanently merged. Fun

The setup is mostly the same so I don't think you will have to. As the only changes are spaghetti clearing.

@SerynEngi
Copy link
Contributor Author

Oh god, this means that I will have to update the wiki page if this is permanently merged. Fun

The setup is mostly the same so I don't think you will have to. As the only changes are spaghetti clearing.

They will have to, somewhat. The ship now complies with the standard O2/N2/CO2/N20/Constricted plasma setup that every other ship runs. It did not do so previously, as the ship (prior to this PR) runs it in the following order: CP/N2/Plasma/N20/CO2/O2.

I've wanted to do this for some time, but other people were modifying the map, and other things took priority.

_maps/map_files/Atlas/atlas.dmm Outdated Show resolved Hide resolved
Bokkiewokkie and others added 2 commits August 4, 2023 19:54
Also adds fire alarm, intercom and some space heaters to atmospherics
Copy link
Contributor

@Bokkiewokkie Bokkiewokkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these last two commits they're the best!

@Bokkiewokkie Bokkiewokkie merged commit fb9bfad into BeeStation:master Aug 18, 2023
9 checks passed
@SerynEngi SerynEngi deleted the AtlasAtmos branch July 21, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants