Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the black skirt and maid outfit to the torp shop #2473

Merged
merged 4 commits into from
Aug 11, 2023

Conversation

DrSirKnight
Copy link
Contributor

@DrSirKnight DrSirKnight commented Jul 12, 2023

About The Pull Request

Adds the black skirt and maid outfit to the torp shop

Why It's Good For The Game

Clothing variety is good

Changelog

🆑
add: Added a maid outfit to the torp shop
add: Added the black skirt to the torp shop
fix: Fixes suitbox slowdown not being removed for certain occasions
/:cl:

Copy link
Contributor

@Kmc2000 Kmc2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤨

Bokkiewokkie
Bokkiewokkie previously approved these changes Jul 28, 2023
Copy link
Contributor

@Bokkiewokkie Bokkiewokkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essential navy equipment

@DrSirKnight
Copy link
Contributor Author

I added a fix to the suitbox not removing the slowdown when it's made into cardboard (you will be stuck with the slowdown forever if you do that), someone should probably port the fix over to beestation as it's likely an issue for them aswell

@DrSirKnight
Copy link
Contributor Author

I added a fix to the suitbox not removing the slowdown when it's made into cardboard (you will be stuck with the slowdown forever if you do that), someone should probably port the fix over to beestation as it's likely an issue for them aswell

THESE THINGS ARE TERRIBLE, I added another fix related to them not removing slowdown when put into disposals, I need a more experienced coder to look over this and see if there's a better way to go about removing the slowdown

@DeltaFire15
Copy link
Contributor

Doesn't dropped() fire after dropping the item so the check for if the user is holding it always ends up false? Don't exactly remember the item drop pipeline, will have to check when I'm back somewhere I can codedive.

@DeltaFire15 DeltaFire15 dismissed Kmc2000’s stale review August 4, 2023 11:36

stale & no content

@Bokkiewokkie Bokkiewokkie merged commit 82a21b6 into BeeStation:master Aug 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants