[UPSTREAM] Fixes signals subfile naming scheme #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bokkiewokkie
approved these changes
Jun 25, 2023
What? |
covertcorvid
approved these changes
Jun 29, 2023
ss13-beebot
added a commit
that referenced
this pull request
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports the following PR from Upstream:
What that PR does is it renames all signals subfiles to the proper naming scheme.
The naming scheme previously used was "[sub] _ [root]" and now the current version is "[root] _ [sub]"
Also while this PR isn't exactly required for...two future specific PRs, it does make it less confusing about where to put what code in what folder once those PRs are being pulled downstream for the final PR.
Why It's Good For The Game
Makes the signal files follow the proper naming scheme.
Makes porting less headache-inducing.
Testing Photographs and Procedure
Screenshots&Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑RKz
code: renamed signal subfiles to match proper naming schemes of "[root] _ [sub]" , not "[sub] _ [root]"
/:cl: