Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get_query_parameters for some requests #106

Open
kevin-pease opened this issue Aug 23, 2024 · 0 comments · May be fixed by #110
Open

Update get_query_parameters for some requests #106

kevin-pease opened this issue Aug 23, 2024 · 0 comments · May be fixed by #110
Labels
enhancement An enhancement of an existing feature

Comments

@kevin-pease
Copy link
Contributor

kevin-pease commented Aug 23, 2024 •
edited
Loading

Some requests containing certain asset types (i.e. alphanum4, alphanum12 and native) have an inelegant way of getting the query parameters. A better way has been implemented in TradeAggregationsRequest. This idea should also be implemented for:

  • DetailsRequest;
  • AllTradesRequest.
@kevin-pease kevin-pease added the enhancement An enhancement of an existing feature label Aug 23, 2024
@kevin-pease kevin-pease linked a pull request Sep 13, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An enhancement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve query parameters methods Baseflow/stellar-rust-sdk
1 participant
@kevin-pease