You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
We are experiencing significant server lag (8%) of tick at higher player counts. It seems to specifically come from me.ryanhamshire.GriefPrevention.DataStore.getClaim() method. https://spark.lucko.me/0oIUisWjFY
ERROR MESSAGE
## Replace me with the error message ##
Additional server information
GriefPrevention version: 16.18.4 BanFromClaim version: 1.7.4 Server version (use /ver): 1.21.1 Plugin list:
The text was updated successfully, but these errors were encountered:
The plugin appears to be checking if the player is in a claim from which they have been banned in a roundabout way. Could we please use DataStore#getClaimAt instead of DataStore#getClaim?
I'm not sure how DataStore#getClaimAtshould be more efficient than DataStore#getClaim. But I will look into it to see if there is any difference between those two.
It seems another plugin (GPFlags), also reported this issue a couple weeks ago, and pushed a fix to change to DataStore#getClaimAt. Here's the GitHub report discussion about it: GriefPrevention/GriefPrevention#2249
Got some info about the issue from RoboMWM, DataStore#getClaimAt operates much different than DataStore#getClaim. As it only gets a subset of claims based on the chunk, rather than all claims, and that the search is in a hashmap makes it more efficient.
Describe the bug
We are experiencing significant server lag (8%) of tick at higher player counts. It seems to specifically come from me.ryanhamshire.GriefPrevention.DataStore.getClaim() method.
https://spark.lucko.me/0oIUisWjFY
ERROR MESSAGE
Additional server information
GriefPrevention version: 16.18.4
BanFromClaim version: 1.7.4
Server version (use /ver): 1.21.1
Plugin list:
The text was updated successfully, but these errors were encountered: