Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows SDK version used for building packages #507

Open
CedricGuillemet opened this issue Dec 2, 2022 · 2 comments
Open

Windows SDK version used for building packages #507

CedricGuillemet opened this issue Dec 2, 2022 · 2 comments
Assignees
Milestone

Comments

@CedricGuillemet
Copy link
Contributor

Latest Windows SDK version seems to be used for Windows package build and release.
This forces user to use the latest version as well.
A variable in the build should be available to set it to a version compatible for most users.

@CedricGuillemet
Copy link
Contributor Author

I'm taking a look

@CedricGuillemet CedricGuillemet self-assigned this Dec 5, 2022
@CedricGuillemet CedricGuillemet added this to the 6.0 milestone Dec 5, 2022
@bghgary bghgary self-assigned this Dec 8, 2022
@bghgary bghgary modified the milestones: 6.0, Future Feb 9, 2023
@bghgary bghgary modified the milestones: Future, 8.0 Apr 16, 2024
@bghgary bghgary removed their assignment Apr 16, 2024
@bghgary bghgary modified the milestones: 8.0, Future Jul 9, 2024
@CedricGuillemet
Copy link
Contributor Author

More context:
All projects using c++ code need to use the same cppwinrt version. Otherwise, linking erros will popup.
For example, RNPermissions was not using the cppwinrt version used for RNW until this PR : https://github.com/zoontek/react-native-permissions/pull/860/files
BRN RNTA build is more explicit

run: cmake -G "Visual Studio 16 2019" -D CMAKE_SYSTEM_NAME=WindowsStore -D CMAKE_SYSTEM_VERSION=10.0.19041.0 -DCMAKE_UNITY_BUILD=true -D CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION_MAXIMUM=10.0.19041.0 -A x64 ./../../../react-native-windows/windows

But next RNW version might change that number and if a user project is using a different version, then nothing will work.
One solution might be to package a .dll of BRN instead. This way, PDB might be packaged as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants