From 54ba5b6c7040ff61444d546e3b14b111e0aeff72 Mon Sep 17 00:00:00 2001 From: Clifford Yapp <238416+starseeker@users.noreply.github.com> Date: Tue, 24 Sep 2024 07:04:36 -0400 Subject: [PATCH] Add a note to beef up the git clone logic for the release case. --- misc/CMake/BRLCAD_EXT_Setup.cmake | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/misc/CMake/BRLCAD_EXT_Setup.cmake b/misc/CMake/BRLCAD_EXT_Setup.cmake index 425fbe4463..425aa1f2e3 100644 --- a/misc/CMake/BRLCAD_EXT_Setup.cmake +++ b/misc/CMake/BRLCAD_EXT_Setup.cmake @@ -128,6 +128,12 @@ function(brlcad_ext_setup) # If not, next up is a bext dir in the build directory. If # one doesn't already exist, try to clone it + + # TODO - need to use the ls-remote trick from above to first check for a branch + # in bext that corresponds to the current release - if we have one, we should + # be using that. As it stands, old releases will pull the very latest release's + # dependencies with this clone, which may not work. We want this only if there + # isn't a matching versioned release branch. set(BRLCAD_EXT_SOURCE_DIR ${CMAKE_CURRENT_BINARY_DIR}/bext) if (NOT EXISTS ${BRLCAD_EXT_SOURCE_DIR}) find_program(GIT_EXEC git REQUIRED)