Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelWriter.WriteExtensibleEnum can generate incorrectly-typed documentation #5069

Open
Arithmomaniac opened this issue Sep 16, 2024 · 0 comments

Comments

@Arithmomaniac
Copy link

See the following generator source:

writer.WriteXmlDocumentationSummary($"Converts a string to a {name:C}.");
writer.Line($"public static implicit operator {cs}({enumType.ValueType} value) => new {cs}(value);");

Note that even when enumType.ValueType is not string, the generated documentation still refers to a string. In the (rare) cases where it isn't a string, it should refer to the actual type (ideally, wrapped in a see cref tag.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant