Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Via creation happen immediately upon calling self.add_via() #10

Open
pvnbhargava opened this issue Oct 8, 2019 · 0 comments
Open
Assignees

Comments

@pvnbhargava
Copy link
Member

The Problem

Currently, self.add_via() creates a Via object which calculates the region to be filled with vias and can be mutated in real time. However, This Via object does not actually try to fill this region until the generator gets finalized.

As a result, any exceptions that may result from of incorrect metal sizing does not show up until the generator finishes, and can not easily be attributed to the line of code which created the via in the first place

Proposed Solution

As soon as self.add_via() is called, we should call the tech class' get_best_via_info() method to determine optimal via sizing for the provided region. This way, if a via is not possible, it will fail immediately. Once this optimal via info is calculated, we can construct a primitive via object with it.

@pvnbhargava pvnbhargava self-assigned this Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant