Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale not passed through #52

Open
alyssarosenzweig opened this issue Aug 26, 2024 · 0 comments
Open

Locale not passed through #52

alyssarosenzweig opened this issue Aug 26, 2024 · 0 comments

Comments

@alyssarosenzweig
Copy link
Member

Outside the VM:

alyssa@blossom ~> locale
LANG=fr_CA.UTF-8
LC_CTYPE="fr_CA.UTF-8"
LC_NUMERIC=en_CA.UTF-8
LC_TIME=en_CA.UTF-8
LC_COLLATE="fr_CA.UTF-8"
LC_MONETARY=en_CA.UTF-8
LC_MESSAGES="fr_CA.UTF-8"
LC_PAPER=en_CA.UTF-8
LC_NAME="fr_CA.UTF-8"
LC_ADDRESS="fr_CA.UTF-8"
LC_TELEPHONE="fr_CA.UTF-8"
LC_MEASUREMENT=en_CA.UTF-8
LC_IDENTIFICATION="fr_CA.UTF-8"
LC_ALL=

Inside the VM:

alyssa@blossom ~ [1]> krun bash
...
alyssa@blossom:~$ locale
LANG=
LC_CTYPE="POSIX"
LC_NUMERIC="POSIX"
LC_TIME="POSIX"
LC_COLLATE="POSIX"
LC_MONETARY="POSIX"
LC_MESSAGES="POSIX"
LC_PAPER="POSIX"
LC_NAME="POSIX"
LC_ADDRESS="POSIX"
LC_TELEPHONE="POSIX"
LC_MEASUREMENT="POSIX"
LC_IDENTIFICATION="POSIX"
LC_ALL=

Incidentally this masked over FEX-Emu/FEX#4010 on Asahi, otherwise my French system would've hit that bug before the user did.

WhatAmISupposedToPutHere pushed a commit to WhatAmISupposedToPutHere/krun that referenced this issue Sep 1, 2024
Change the approach to environment variables to delete ones
that are likely to cause problems instead of only passing through
a pre-approved list.
This will be neccessary to correctly work as a binfmt handler

Fixes: AsahiLinux#52
Signed-off-by: Sasha Finkelstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant