Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port] EFN Noise filter #604

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

QuacksQ
Copy link
Contributor

@QuacksQ QuacksQ commented Jul 14, 2024

About The Pull Request

This pr ports a extremely subtle noise filter from EFN.
Extremely minor change if you ask me but its gonna add a little more soul and thats what we love.
Jokes aside this will add to the atmosphere of the server being aboard a run down ship in deep space.

Watch testing videos in full screen to see the difference the best, or load up this branch to see it yourself.

Credit goes to EFN for the idea:

How Does This Help Gameplay?

More soul is always nice, Noise filter has no impact on the visual clarity with how subtle it is.

How Does This Help Roleplay?

Minimal impact on RP.

Proof of Testing

Screenshots/Videos

Without noise filter

2024-07-15.00-16-34.mp4

With noise filter. (Watch in fullscreen, its that subtle!)

2024-07-15.00-17-06.mp4

Changelog

🆑
add: Added a subtle noise filter for soul purposes.
/:cl:

@github-actions github-actions bot added Feature How I broke the server in one easy step! Sprites I like pretty things. labels Jul 14, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale "Anyone home?" label Jul 22, 2024
@github-actions github-actions bot closed this Jul 29, 2024
@RimiNosha RimiNosha removed the Stale "Anyone home?" label Jul 29, 2024
@RimiNosha RimiNosha reopened this Jul 29, 2024
@ChungusGamer666
Copy link
Contributor

full disclosure: the noise plane is actually quite pointless and you can safely put noise in the fullscreen plane with a high layer

@QuacksQ
Copy link
Contributor Author

QuacksQ commented Aug 3, 2024

full disclosure: the noise plane is actually quite pointless and you can safely put noise in the fullscreen plane with a high layer

Artea can have a little bloat, as a snack
thanks for pointing this out tho

@QuacksQ QuacksQ requested a review from RimiNosha August 17, 2024 18:58
Copy link
Contributor

@RimiNosha RimiNosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make this a pref down the line, but I don't really see anyone having a real issue with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature How I broke the server in one easy step! Sprites I like pretty things.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants