-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Port] EFN Noise filter #604
base: master
Are you sure you want to change the base?
[Port] EFN Noise filter #604
Conversation
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
full disclosure: the noise plane is actually quite pointless and you can safely put noise in the fullscreen plane with a high layer |
Artea can have a little bloat, as a snack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make this a pref down the line, but I don't really see anyone having a real issue with this.
About The Pull Request
This pr ports a extremely subtle noise filter from EFN.
Extremely minor change if you ask me but its gonna add a little more soul and thats what we love.
Jokes aside this will add to the atmosphere of the server being aboard a run down ship in deep space.
Watch testing videos in full screen to see the difference the best, or load up this branch to see it yourself.
Credit goes to EFN for the idea:
How Does This Help Gameplay?
More soul is always nice, Noise filter has no impact on the visual clarity with how subtle it is.
How Does This Help Roleplay?
Minimal impact on RP.
Proof of Testing
Screenshots/Videos
Without noise filter
2024-07-15.00-16-34.mp4
With noise filter. (Watch in fullscreen, its that subtle!)
2024-07-15.00-17-06.mp4
Changelog
🆑
add: Added a subtle noise filter for soul purposes.
/:cl: