[PORT] The recoilening #589
Conversation
github-actions
bot
added
Port
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
|
Fuck you dont stale my shit |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
|
i did this on efn too, look at my implementation perhaps and see if ita better or worse idk |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself. |
| var/mpx = sin(angle) * strength | ||
| var/mpy = cos(angle) * strength | ||
| animate(sufferer, pixel_x = oldx+mpx, pixel_y = oldy+mpy, time = duration, flags = ANIMATION_RELATIVE) | ||
| animate(pixel_x = oldx, pixel_y = oldy, time = backtime_duration, easing = BACK_EASING) |
There was a problem hiding this comment.
Not sure how I feel about this being a whole file by itself, but the code otherwise checks out.
About The Pull Request
This pr is a port of:
This PR significantly improves recoil (screenshake when shooting guns) because our current recoil sucks ass. Instead of a simple screenshake its now based on the direction you're shooting in. I have also gone ahead and added recoil values to the guns we have in-game right now.
Ballistic guns have a recoil value of
1Energy guns have a recoil value of
0.2Disablers and the Miniature energy gun have a recoil value of because they're tiny
0.1This is yet another expansion of the guns and other cool shit pr's like: #520 #455 and #460.
How Does This Help Gameplay?
Feedback to in game actions is always good and guns not having recoil when being shot is just weird.
How Does This Help Roleplay?
Immersion probably
Proof of Testing
Screenshots/Videos
Old Recoil
2024-06-01.12-47-22.mp4
New Recoil
2024-06-01.12-54-12.mp4
New recoil on a disabler
2024-06-01.13-19-53.mp4
Changelog
🆑
qol: Recoil is alot less awful now and is based on the direction you're shooting in.
/:cl: