Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test React SDK #428

Open
gershon opened this issue Aug 27, 2024 · 7 comments
Open

Test React SDK #428

gershon opened this issue Aug 27, 2024 · 7 comments
Assignees
@dhruvmalik007
Labels
app:sdk Ark Project SDK difficulty: medium To resolve the issue, it is necessary to gain an understanding of some aspects of the codebase priority: high status: help wanted Extra attention is needed

Comments

@gershon
Copy link
Contributor

gershon commented Aug 27, 2024

Is this feature related to a problem? Please describe.

React SDK is not tested.

Describe the solution you'd like

Write tests using React Testing Library.
@gershon gershon added difficulty: medium To resolve the issue, it is necessary to gain an understanding of some aspects of the codebase priority: high app:sdk Ark Project SDK status: help wanted Extra attention is needed labels Aug 27, 2024
@od-hunter
Copy link

od-hunter commented Aug 27, 2024 •
edited
Loading

Hi, Can I work on this please @gershon . I’m ready to work.

@ooochoche
Copy link

ooochoche commented Aug 27, 2024 •
edited
Loading

I’m available to work on this @gershon

@gershon
Copy link
Contributor Author

gershon commented Aug 27, 2024

Hi @od-hunter , go ahead, let me know if you need any assistance.

@gershon
Copy link
Contributor Author

gershon commented Aug 27, 2024

Hi @ooochoche, there will be other issues open for contribution in near future, thanks for offering!

@od-hunter
Copy link

Hello @gershon , so sorry I wouldn’t be able to do this anymore, @ooochoche can just go ahead. Decided to let you know on time. My apologies please.🙏🏼

@Joy-Adah
Copy link

Hi @gershon can I take this up?

dhruvmalik007 added a commit to dhruvmalik007/ark-project that referenced this issue Sep 12, 2024
@dhruvmalik007
WIP: Issue ArkProjectNFTs#428 : Start adding test methods for create …
57e07c1 
…auction and wrapper provider
@dhruvmalik007
Copy link

Hey @gershon ,

i am handling this request in #451 , let me know if this has to be mock unit tests or workflow tests ? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvmalik007 dhruvmalik007

Labels
app:sdk Ark Project SDK difficulty: medium To resolve the issue, it is necessary to gain an understanding of some aspects of the codebase priority: high status: help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gershon @dhruvmalik007 @Joy-Adah @ooochoche @od-hunter