Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh building #294

Open
KarolDaniluk opened this issue Sep 8, 2020 · 6 comments
Open

Refresh building #294

KarolDaniluk opened this issue Sep 8, 2020 · 6 comments
Labels
anno canvas Issues affecting the anno canvas enhancement New feature or request question Further information is requested

Comments

@KarolDaniluk
Copy link

Hello
Currently we have an option called Place Building that puts a new building with given size, color, icon, label and options.
However it would be great if next to it there would be a Refresh Building button, that instead of placing a new building would change options of selected buildings. Sometimes there is a need of changing one option on multiple objects (like road tiles) and placing them all over again is time consuming.
Thanks

@StingMcRay StingMcRay added anno canvas Issues affecting the anno canvas enhancement New feature or request question Further information is requested labels Sep 8, 2020
@StingMcRay
Copy link
Contributor

StingMcRay commented Sep 1, 2021

For coloring objects, we have the repaint option, so no need to replacing objects
afbeelding
You can use colors you already have used (or even choice first a new color), then select all objects you want to change color with and then use this button
For other options, like influence Range / distance, naming, icons yes you must change options before and then hit the "place building" button

@FroggieFrog
Copy link
Collaborator

Maybe a change in how the app works is needed.
Currently the app is always in a "place object" mode.
I can imagine an "edit object" mode. When an object from the canvas is selcted, the Building Settings section displays all settings of the selected building and the Place Building button changes to Apply Changes.

Of course there are some open questions like

  • What happens when the size is changed and there is not enough space available?
  • What happens if multiple objects are selected?
  • How to change between those modes? (Maybe enter "place object" mode after double click on tree view?)

So any feedback/ideas/PRs are welcome.

@StingMcRay
Copy link
Contributor

StingMcRay commented Sep 1, 2021

I'm still in thinking of a custom preset file, that can be read in next to the default Presets....
Maybe we can use that also to add "user own custom" building to it (with an input screen or something)
only we need to add the custom building to the existing data of the tree, to avoid "restarts" of the program
and next time user runs the program, it is loaded with the custom preset so he can reuse it again then
(still an idea i walk around with for some months :))

@FroggieFrog
Copy link
Collaborator

You mean something like #158?

@StingMcRay
Copy link
Contributor

Something like that, also that color.json should be a choice as well

@Atria1234
Copy link
Collaborator

We could add another button "Apply changes" which would be disabled when nothing is selected. It would probably be added below "Place building" button and user could specify which properties should be applied (color/influence type/influence range/borderless/label/icon/...). And it would apply those properties to all selected objects.

Changing size could be excluded to avoid problems with collision, but if you would really want it, it shouldn't be that hard to check for collisions before applying changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anno canvas Issues affecting the anno canvas enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants