Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUILD: actually fix review checklist #812

Merged
merged 1 commit into from
Jun 21, 2023
Merged

BUILD: actually fix review checklist #812

merged 1 commit into from
Jun 21, 2023

Conversation

mehalter
Copy link
Member

Debugged and validated solution on my own fork: mehalter#1

@mehalter mehalter requested a review from epatters June 21, 2023 22:09
epatters
epatters approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for slogging through. Sounds like it has been a pain.

@mehalter mehalter merged commit 3bed069 into main Jun 21, 2023
11 of 12 checks passed
@mehalter
Copy link
Member Author

It was a bit painful 😅 I just tested it (#813) and it worked great!

@mehalter mehalter deleted the checklist_fix branch June 21, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epatters epatters epatters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehalter @epatters