Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Logo colors not appropriate for dark mode. #1209

Closed
rahulharpal1603 opened this issue Jul 13, 2024 · 2 comments · Fixed by https-gitlab-com-OKEAMAH002/web3-Wallet-login#3 · 4 remaining pull requests
Closed

[BUG] Logo colors not appropriate for dark mode. #1209

rahulharpal1603 opened this issue Jul 13, 2024 · 2 comments · Fixed by https-gitlab-com-OKEAMAH002/web3-Wallet-login#3 · 4 remaining pull requests
Labels
Bug

Comments

@rahulharpal1603
Copy link
Contributor

rahulharpal1603 commented Jul 13, 2024 •
edited
Loading

GitHub and Algolia Logo blend into the dark background.

Bug description

When we switch to dark mode, the GitHub and Algolia logos retain their previous colours only. That is why, it makes it difficult to see them on the webpage.

To Reproduce

Visit the home page: https://react-tooltip.com/ and change the theme to dark mode.

Expected behaviour

GitHub and Algolia's logos should change to a lighter version when switched to dark mode.

Screenshots

image
image
@rahulharpal1603
Copy link
Contributor Author

@gabrieljablonski, can I take up this issue and fix it?

@gabrieljablonski
Copy link
Member

@rahulharpal1603 go for it

@rahulharpal1603 rahulharpal1603 mentioned this issue Jul 23, 2024
Merged
@michalJakubis michalJakubis mentioned this issue Aug 26, 2024
Open
@N3wt0n1ssaak N3wt0n1ssaak mentioned this issue Aug 26, 2024
Open
@OKEAMAH OKEAMAH mentioned this issue Aug 26, 2024
Merged
@PierreGode PierreGode mentioned this issue Sep 4, 2024
Open
This was referenced Sep 13, 2024
Open
Open
Open
@AlbertChambers AlbertChambers mentioned this issue Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade react-tooltip from 5.26.3 to 5.28.0 https-gitlab-com-OKEAMAH002/web3-Wallet-login
[Snyk] Upgrade react-tooltip from 5.27.1 to 5.28.0 Kentico/xperience-by-kentico-azure-ai-search
[Snyk] Upgrade react-tooltip from 5.27.1 to 5.28.0 N3wt0n1ssaak/authentik
[Snyk] Upgrade react-tooltip from 5.26.4 to 5.28.0 PierreGode/authentik
[Snyk] Upgrade: , , sharp, dayjs, jose, lucide-react, nanostores, npm-check-updates, playwright, react-tooltip, zustand, tailwind-merge AlbertChambers/developer-roadmap
[Snyk] Upgrade: , , sharp, dayjs, jose, lucide-react, nanostores, npm-check-updates, playwright, react-tooltip, zustand, tailwind-merge AlbertChambers/developer-roadmap
[Snyk] Upgrade: , , sharp, dayjs, jose, lucide-react, nanostores, npm-check-updates, playwright, react-tooltip, zustand, tailwind-merge AlbertChambers/developer-roadmap
[Snyk] Upgrade: , , sharp, dayjs, jose, lucide-react, nanostores, npm-check-updates, playwright, react-tooltip, zustand, tailwind-merge AlbertChambers/developer-roadmap
2 participants
@gabrieljablonski @rahulharpal1603