fix(swing-store)!: Remove unsafe hostStorage.setExportCallback method #10063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
7ebfc76
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9df72c56.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-10062-remove-setexpor.agoric-sdk.pages.dev |
mhofman
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10062
Description
Removes
hostStorage.setExportCallback(), for reasons explained in #10062.Security Considerations
This will prevent unlikely but possible uses of the method which would cause misleading behavior.
Scaling Considerations
n/a
Documentation Considerations
This removes mention of the method from the only place where it is documented. No historical note is added because we never use it anyway.
Testing Considerations
n/a
Upgrade Considerations
None known because the method is not in active use.