Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove reliance on agoric run in shell path #98

Open
turadg opened this issue Feb 8, 2024 · 1 comment
Open

remove reliance on agoric run in shell path #98

turadg opened this issue Feb 8, 2024 · 1 comment

Comments

@turadg
Copy link
Member

turadg commented Feb 8, 2024

Problem to be solved

A couple modules in the synthetic-chain package need to run builder scripts for core-evals. They do this now calling out to agoric run in a child process: https://github.com/search?q=repo%3AAgoric%2Fagoric-3-proposals%20%22agoric%20run%22&type=code

This creates a dependence on the shell environment.

Added context

Design

agoric run is implemented in JS. Have agoric-sdk export the necessary functions to do the work and have a3p import them.

@turadg
Copy link
Member Author

turadg commented Aug 23, 2024

This tech debt added work to Agoric/agoric-sdk#9945 in the form of a build failure: https://github.com/Agoric/agoric-sdk/actions/runs/10529314379/job/29176823312?pr=9945

As a stop-gap, the package could admit its dependence on agoric CLI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant