Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake: extra 1000000 in the provision pool #95

Open
turadg opened this issue Feb 7, 2024 · 0 comments
Open

flake: extra 1000000 in the provision pool #95

turadg opened this issue Feb 7, 2024 · 0 comments

Comments

@turadg
Copy link
Member

turadg commented Feb 7, 2024

Working on #88 I often get an error in upgrade-8 checking the provision pool balance:

# ensure there's nothing in the provision pool
BALANCE="$(agd q bank balances agoric1megzytg65cyrgzs6fvzxgrcqvwwl7ugpt62346 -o json)"
test_val "$(echo $BALANCE | jq -r '.balances | length')" "0" "provisionpool balance should be empty but was $BALANCE"

In https://github.com/Agoric/agoric-3-proposals/actions/runs/7809408199/job/21301178798 we saw something similar during upgrade-10:

#1446 [use-upgrade-10 linux/amd64 use-upgrade-10 3/3] RUN ./run_use.sh 34:upgrade-10
#1446 7.297   ✘ [fail]: Pre Vault tests Test failed via `t.fail()`
#1446 7.321   ─
#1446 7.321 
#1446 7.321   Provision pool has right balance
#1446 7.321 
#1446 7.321   pre.test.js:87
#1446 7.321 
#1446 7.321    86:                                               
#1446 7.321    87:   t.is(result.balances[0].amount, '19000000');
#1446 7.321    88: });                                           
#1446 7.321 
#1446 7.321   Difference (- actual, + expected):
#1446 7.321 
#1446 7.321   - '18000000'
#1446 7.321   + '19000000'

The amount may just be a coincidence, or due to some race. Regardless there's some flakiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant