Merge pull request #2015 from Agenta-AI/fix/baseresponse-in-human-eva…

…luation-view Fix FuncResponse/BaseResponse in human evaluation views
Agenta-AI · Aug 23, 2024 · 8efcea1 · 8efcea1
2 parents 1dec2c6 + 7fc0e6e
commit 8efcea1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/agenta-web/src/components/EvaluationTable/ABTestingEvaluationTable.tsx b/agenta-web/src/components/EvaluationTable/ABTestingEvaluationTable.tsx
@@ -311,15 +311,18 @@ const ABTestingEvaluationTable: React.FC<EvaluationTableProps> = ({
 
                     let res: BaseResponse | undefined
 
-                    if (isFuncResponse(result)) {
+                    if (typeof result === "string") {
+                        res = {version: "2.0", data: result} as BaseResponse
+                    } else if (isFuncResponse(result)) {
                         res = {version: "2.0", data: result.message} as BaseResponse
                     } else if (isBaseResponse(result)) {
                         res = result as BaseResponse
                     } else {
-                        res = {version: "2.0", data: result} as BaseResponse
+                        res = {version: "2.0", data: ""} as BaseResponse
+                        console.error("Unknown response type:", result)
                     }
 
-                    let _result = getStringOrJson(res)
+                    let _result = getStringOrJson(res.data)
 
                     setRowValue(rowIndex, variant.variantId, _result)
                     ;(outputs as KeyValuePair)[variant.variantId] = _result

diff --git a/agenta-web/src/components/EvaluationTable/SingleModelEvaluationTable.tsx b/agenta-web/src/components/EvaluationTable/SingleModelEvaluationTable.tsx
@@ -344,15 +344,18 @@ const SingleModelEvaluationTable: React.FC<EvaluationTableProps> = ({
 
                     let res: BaseResponse | undefined
 
-                    if (isFuncResponse(result)) {
+                    if (typeof result === "string") {
+                        res = {version: "2.0", data: result} as BaseResponse
+                    } else if (isFuncResponse(result)) {
                         res = {version: "2.0", data: result.message} as BaseResponse
                     } else if (isBaseResponse(result)) {
                         res = result as BaseResponse
                     } else {
-                        res = {version: "2.0", data: result} as BaseResponse
+                        res = {version: "2.0", data: ""} as BaseResponse
+                        console.error("Unknown response type:", result)
                     }
 
-                    let _result = getStringOrJson(res)
+                    let _result = getStringOrJson(res.data)
 
                     setRowValue(rowIndex, variant.variantId, _result)
                     ;(outputs as KeyValuePair)[variant.variantId] = _result