Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACF Fields disappear when setting templateLock="contentOnly" #880

Open
chrismademe opened this issue Oct 26, 2023 · 1 comment
Open

ACF Fields disappear when setting templateLock="contentOnly" #880

chrismademe opened this issue Oct 26, 2023 · 1 comment

Comments

@chrismademe
Copy link

Describe the bug
On an ACF block, when using InnerBlocks and setting the templateLock prop to "contentOnly", the fields disppear from the sidebar. When using the "all" or "insert" values, they remain.

To Reproduce
Steps to reproduce the behavior:

  1. Create an ACF block with at least 1 custom field
  2. Add InnerBlocks support to the block with `"supports": { "jsx": true }
  3. Create some mark and include the <InnerBlocks /> component
  4. Add templateLock="contentOnly" to the InnerBlocks component and your fields will disappear from the sidebar

Expected behavior
ACF fields should remain for all templateLock values.

Screenshots or Video
Screenshot 2023-10-26 at 13 05 15
Screenshot 2023-10-26 at 13 05 27

Version Information:

  • WordPress Version 6.3.2
  • PHP Version 8.1.23
  • ACF Version ACF PRO 6.3
  • Browser All browsers
@CreativeDive
Copy link
Collaborator

This is a tricky one. The ACF field can only refer to the content, but also to the design. Therefore, just showing all ACF fields in case of contentOnly is not the right way.

To do it properly, something would have to be defined for each ACF field depending on whether it is a content field or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants