Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Output folder now contains a lot of files that don't belong to Duality #875

Open
ilexp opened this issue Jul 17, 2020 · 6 comments
Open
Assignees
Labels
Bug It's broken and should be fixed DevTool Area: Development tools and environment
Milestone

Comments

@ilexp
Copy link
Member

ilexp commented Jul 17, 2020

Summary

I'm not sure what happened, or when exactly it happened, but my build output folder now looks like this:

explorer_p7Dev4Kbsf

There is a ton of files and folders that have nothing to do with Duality or the editor, which is confusing at best and could somehow end up in some packaged binary in the worst case. Can we get back to the old state?

Analysis

  • Could this have something to do with the recent addition of DualityBenchmarks?
@ilexp ilexp added Bug It's broken and should be fixed DevTool Area: Development tools and environment labels Jul 17, 2020
@ilexp ilexp added this to the 4.0 milestone Jul 17, 2020
@ilexp
Copy link
Member Author

ilexp commented Jul 17, 2020

@Barsonax Assigning you, because you probably have the best idea of any of us how this might have happened, or how to address it.

@Barsonax
Copy link
Member

Barsonax commented Jul 17, 2020

This is the output of the benchmarks. They need to end up in the same folder so that everything is available else things don't work correctly.

It would indeed be cleaner if the output ends in its own folder but we have to make sure it can still load all the required dlls.

@Barsonax
Copy link
Member

Same happens atm with the unit tests btw

@Barsonax
Copy link
Member

Barsonax commented Jul 23, 2020

This is not really a blocked I think for v4.0. Its not pretty but everything does work (and it only affects developers of duality, not users) as it should so I think we should remove it from the 4.0 milestone so its not blocking for the release @ilexp

@ilexp ilexp modified the milestones: 4.0, General Jul 23, 2020
@ilexp
Copy link
Member Author

ilexp commented Jul 23, 2020

Agreed, moved it out of the milestone.

@ilexp
Copy link
Member Author

ilexp commented Dec 28, 2020

Moving this into 4.0 again, since we're currently in a somewhat slow / stale mode, making it more important to have a clean dev environment, both for picking up again later and providing a better place for new contributors to start.

@ilexp ilexp modified the milestones: General, 4.0 Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug It's broken and should be fixed DevTool Area: Development tools and environment
Development

No branches or pull requests

2 participants