Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to call git from the path in the VersionUpdater without searching for specific locations #792

Open
SirePi opened this issue Apr 20, 2020 · 1 comment
Open

Try to call git from the path in the VersionUpdater without searching for specific locations #792

SirePi opened this issue Apr 20, 2020 · 1 comment
Labels
DevTool Area: Development tools and environment Nice2Have Beneficial, but only very slightly so

Comments

@SirePi
Copy link
Member

SirePi commented Apr 20, 2020

Summary

As of today, the VersionUpdater tool has a couple of hardcoded paths where it looks for the git executable to perform its functions.
Probably it would make sense to have a first go for the PATH bound git.exe, without looking in other folders first.
@SirePi SirePi added Nice2Have Beneficial, but only very slightly so DevTool Area: Development tools and environment labels Apr 20, 2020
@Barsonax
Copy link
Member

Barsonax commented Apr 28, 2020 •
edited
Loading

This would be a nice improvement. I think however that we would also solve this (and other executable dependencies) if we moved to more modern build tooling: #810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DevTool Area: Development tools and environment Nice2Have Beneficial, but only very slightly so
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SirePi @Barsonax