Template workflows not failing when issue validation is failing

[npalm]

Describe the bug

When the issue is not validated correct by the action, thw workflow still continues and tries to process all the steps.

To Reproduce

Setup the repo as described

1. Create ticket without ticket field, or a typo in the target org
2. Submit issue, and wacht the promotion workflow
3. Validation step is marked ok, details will contain errors.

Expected behavior

Should the validate not error the worklfow in case of a failure?

[stebje]

Hi @npalm, agreed: if there's an error in a step then we should set an error message using core.setFailed. The workflow step can then still be allowed to continue if the user wants that using continue-on-error: true if needed.

Right now it seems that the cli only validates that the input parameters are present, not that they are valid.

Three options as I see it:

1. Validate the integrity of the parsed issue data during parsing
2. Add additional logic to the executor
3. Implement separate class or module for validation that is called by either the executor or parse action

I'd be in favour of adding this logic independently from the issue-parser, as it makes sense to validate the data as early as possible also if the cli tool is used standalone.

Thoughts? 💡