Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected validation behavior on filters with validators #574

Open
mogman1 opened this issue May 30, 2024 · 0 comments · May be fixed by #575
Open

Unexpected validation behavior on filters with validators #574

mogman1 opened this issue May 30, 2024 · 0 comments · May be fixed by #575

Comments

@mogman1
Copy link

mogman1 commented May 30, 2024

Given the following interaction, I would expect behavior around validations to be:

class Foo < ::ActiveInteractin::Base
  string :bar
  validates :bar, presence: true
end

x = Foo.new
x.valid? == false # it's actually nil
x.bar = "baz"
x.valid? == true # unfortunately it's still nil

In each test, rather than the boolean expected, I'm seeing nil returned. In the first example, that's at least still falsey, but it's not the behavior I'd expect from a typical failed validation using vanilla ActiveModel validations. In the second example that should cure the validation problem, but I still see nil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant