Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent error on replaceCommon and notnull #196

Open
camlafit opened this issue Nov 30, 2023 · 1 comment
Open

Prevent error on replaceCommon and notnull #196

camlafit opened this issue Nov 30, 2023 · 1 comment

Comments

@camlafit
Copy link

Hi

At https://github.com/ATM-Consulting/dolibarr_module_abricot/blob/main/includes/class/class.seedobject.php#L1490 test looks incomplete

We can raise an warning/error if notnull key is unset. Could be nice to replace by :

                        if (isset($this->fields[$key]['notnull']) && $this->fields[$key]['notnull'] == 1 && empty($values[$key]))

@atm-florianm
Copy link
Contributor

Hi, what function should your test go in? The line numbers have changed since your issue was opened, so L1490 no longer seems to be the line you were targeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants