Add Prompt primitive #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 95.80% 95.72% -0.09%
==========================================
Files 17 17
Lines 7581 7666 +85
==========================================
+ Hits 7263 7338 +75
- Misses 318 328 +10
☔ View full report in Codecov by Sentry. |
|
@xpromache I'd like to get this one in for a misson I'm working on, but if you have a better idea of how to implement it I'd love to hear it. |
|
I looked through the standard and your implementation makes sense. I agree that if the user triggers a Prompt PDU it has to be the highest priority; if there is a file being sent, you don't want to wait for the EOF, it doesn't make any sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a prompt primitive to trigger a prompt NAK or prompt KeepAlive PDU from the mission specific User process.
I tried to be maximally flexible about when prompts could be generated in the Send, but it just ended up being the highest priority PDU for the Send transaction. At first I was not totally sold on the idea, but it mirrors the Recv's handling of prompt so maybe it is okay. I also figure, if the mission is trying to send a Prompt it should be handle ASAP.
thoughts @xpromache ?
closes #34