Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider setting the CMAKE_MSVC_RUNTIME_LIBRARY variable to use /MD in all build configurations on Windows #2341

Open
wantehchang opened this issue Jul 29, 2024 · 0 comments
Open

Consider setting the CMAKE_MSVC_RUNTIME_LIBRARY variable to use /MD in all build configurations on Windows #2341

wantehchang opened this issue Jul 29, 2024 · 0 comments

Comments

@wantehchang
Copy link
Collaborator

Right now we compile our source files with /MDd in the Debug build configuration on Windows. This causes linker warnings in Debug build if the external dependencies are compiled with /MD (because we build them in the Release build configuration).

We should consider setting the CMAKE_MSVC_RUNTIME_LIBRARY variable to use /MD in all build configurations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wantehchang