Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix evolve base state with new time-stepping scheme #27

Open
doreenfan opened this issue Nov 6, 2018 · 1 comment
Open

Fix evolve base state with new time-stepping scheme #27

doreenfan opened this issue Nov 6, 2018 · 1 comment

Comments

@doreenfan
Copy link
Collaborator

Issue can be reproduced using inputs_3d_C.128.avgbase.dr for uneven base state spacing, and inputs_3d_C.128.avgbase.dx for even base state spacing. Both tests fail after approx. 20 time steps, near the base_cutoff_radius. Backtrace files show that error is due to either a failure to converge during MAC projection, or eos failure to compute enthalpy outside base_cutoff_radius in UpdateScal().
@ajnonaka
Copy link
Contributor

Mostly fixed; still using the original make_w0 for the velocity splitting. If this approach would be simplified it would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajnonaka @doreenfan