Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omit_rows.py program is not robust #99

Open
tashrifbillah opened this issue Feb 6, 2024 · 1 comment
Open

omit_rows.py program is not robust #99

tashrifbillah opened this issue Feb 6, 2024 · 1 comment
Labels

Comments

@tashrifbillah
Copy link
Contributor

The way we wrote this algorithm without Pandas, does not hold true when there is a line break within a cell. We noticed this issue with ampscz_pps01_baseline.csv.

So the suggestion is to verify line number using vim. If line number+2 matches reported lines, omit_rows.py could be used. Otherwise, the problematic lines need to be removed manually through vim. For files with line breaks, identifying the problematic lines through vim is also a difficult task.

FIX: use pandas to read, write NDA compatible CSV file.

@tashrifbillah tashrifbillah changed the title omit_rows.py program is not robus omit_rows.py program is not robust May 23, 2024
@tashrifbillah tashrifbillah reopened this May 23, 2024
@tashrifbillah
Copy link
Contributor Author

We circumvented this issue by removing within-cell line breaks for some data structures. Example tbi01:
358ae98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant